sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

[subnet decap] Fix VLAN prefix decap term

Open lolyu opened this issue 1 year ago • 2 comments

Why I did it

If subnet decap is enabled on T0, the subnet decap term should be created for VLAN prefixes.

Signed-off-by: Longxiang Lyu [email protected]

Work item tracking
  • Microsoft ADO (number only): 28316828

How I did it

For VLAN prefixes, if subnet decap is enabled, created MP2MP decap terms with subnet type vlan and under the subnet decap tunnels.

How to verify it

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111
  • [ ] 202205
  • [ ] 202211
  • [ ] 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

lolyu avatar Jun 06 '24 08:06 lolyu

Is it already included https://github.com/sonic-net/sonic-buildimage/blob/6968aaa85d37b6d83549d0d4ea25c56d16f7207f/dockers/docker-orchagent/ipinip.json.j2#L45-L49 ?

bingwang-ms avatar Jun 06 '24 22:06 bingwang-ms

Discussed offline with @bingwang-ms, let's keep both the IP and subnet decap terms for VLAN.

lolyu avatar Jun 07 '24 05:06 lolyu

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-buildimage/pull/20292

mssonicbld avatar Sep 18 '24 07:09 mssonicbld