sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

[Nokia][supervisor] add linecard_reboot_timeout value to platform_env.conf for Nokia-IXR7250E platform

Open mlok-nokia opened this issue 1 year ago • 1 comments

Why I did it

This PR add the platform specified linecard_reboot_timeout value to the platform_evn.conf. It works PR https://github.com/sonic-net/sonic-platform-daemons/pull/480 and https://github.com/sonic-net/sonic-utilities/pull/3292 to address issue https://github.com/sonic-net/sonic-buildimage/issues/18540

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add line "linecard_reboot_timeout=180" to Nokia-IXR7250E Supervisor platform_env.conf file. This will allow the chassisd to derive the linecard_reboot_timeout value.

Related PRs: https://github.com/sonic-net/sonic-utilities/pull/3292 https://github.com/sonic-net/sonic-platform-daemons/pull/480 https://github.com/sonic-net/sonic-buildimage/pull/18805

How to verify it

This PR requires PRhttps://github.com/sonic-net/sonic-utilities/pull/3292 and to work with

  1. Test expected log. Use the CLI command "sudo reboot" to reboot a linecard, then check the syslog on Supervisor. The below message is logged
Apr 25 19:44:40.818378 ixre-cpm-chassis7 WARNING pmon#chassisd: Expected: Module LINE-CARD0 lost midplane connectivity
  1. Test unepxpected log. Using "sudo /sbin/reboot" or reboot a linecard with any crash method, then ccheck the syslog on Supervusor. The below message is logged.
Apr 25 19:50:22.549416 ixre-cpm-chassis7 WARNING pmon#chassisd: Unexpected: Module LINE-CARD0 lost midplane connectivity
  1. Test the expexcted reboot with timeout case. Use the CLI command "sudo reboot" on linecard. and keep it down for more than 4 minutes. The below messages are logged.
Apr 25 01:25:53.877143 ixre-cpm-chassis7 WARNING sr_device_mgr: Unable to reach slot 1 (Linecard) via Midplane
Apr 25 01:25:58.402511 ixre-cpm-chassis7 WARNING pmon#chassisd: Module LINE-CARD0 went off-line!
Apr 25 01:26:01.658959 ixre-cpm-chassis7 WARNING pmon#chassisd: Expected: Module LINE-CARD0 lost midplane connectivity.
( 3 minutes after the first log)
Apr 25 01:29:10.259527 ixre-cpm-chassis7 WARNING pmon#chassisd: Unexpected: Module LINE-CARD0 midplane connectivity is not restored in 180 seconds

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111
  • [x] 202205
  • [ ] 202211
  • [ ] 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mlok-nokia avatar May 03 '24 14:05 mlok-nokia

@deepak-singhal0408 Per PR https://github.com/sonic-net/sonic-platform-daemons/pull/480 review comment, This PR is Platform specified data which define the linecard_reboot_timeout in platform_env.conf file for Nokia-IXR7250E platform. Please review it.

mlok-nokia avatar May 03 '24 14:05 mlok-nokia

@deepak-singhal0408 This PR a platform specified data (linecard_reboot_timeout=180) which is associated with https://github.com/sonic-net/sonic-platform-daemons/pull/480 and allow each vendor has own value. If this define is not found, the linecard_reboot_timeout will default to 180 seconds. Do we need merge this PR? I think it is good to merge it, so that other vendor can use it as example when they need to use a different value.

mlok-nokia avatar May 24 '24 17:05 mlok-nokia

@deepak-singhal0408 This PR a platform specified data (linecard_reboot_timeout=180) which is associated with sonic-net/sonic-platform-daemons#480 and allow each vendor has own value. If this define is not found, the linecard_reboot_timeout will default to 180 seconds. Do we need merge this PR? I think it is good to merge it, so that other vendor can use it as example when they need to use a different value.

yes Marty.. we need to merge this PR as well..

deepak-singhal0408 avatar May 24 '24 17:05 deepak-singhal0408

/azpw run Azure.sonic-buildimage

deepak-singhal0408 avatar May 24 '24 17:05 deepak-singhal0408

/azpw run

deepak-singhal0408 avatar May 24 '24 18:05 deepak-singhal0408

/Azp run Azure.sonic-buildimage

gechiang avatar May 28 '24 20:05 gechiang

Commenter does not have sufficient privileges for PR 18862 in repo sonic-net/sonic-buildimage

azure-pipelines[bot] avatar May 28 '24 20:05 azure-pipelines[bot]

/Azp run Azure.sonic-buildimage

arlakshm avatar May 28 '24 20:05 arlakshm

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 28 '24 20:05 azure-pipelines[bot]

/Azpw run

deepak-singhal0408 avatar May 29 '24 05:05 deepak-singhal0408

MSFT ADO: 28164943

deepak-singhal0408 avatar May 29 '24 18:05 deepak-singhal0408

@rlhui could you please help merge? @gechiang FYI.

deepak-singhal0408 avatar May 29 '24 18:05 deepak-singhal0408

MSFT ADO: 28164943

Please do not reuse ADO from different PR eventhough they are related. Each PR needs its own ADO. Please create a new one for this one. @deepak-singhal0408

gechiang avatar Jun 04 '24 20:06 gechiang