sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

[Nokia][sonic-platform] Update nokia sonic-platform submodule with thermal coherence changes to be paired with NDK >= 22.9.26

Open snider-nokia opened this issue 10 months ago • 1 comments

These changes ensure proper thermal subsystem operation when removing ASIC internal thermal sensor polling from NDK. - Please pair this submodule update with NDK >= 22.9.26 : NDK 22.9.26 PR is here: https://github.com/Azure/sonic-buildimage-msft/pull/316 - This PR is 202205 specific. The associated master PR is here: https://github.com/sonic-net/sonic-buildimage/pull/18564

Edit: Now also includes kernel module changes for error level messages to warning level (this change is 202205 specific and not applicable to master).

Why I did it

These changes are required in order to ensure thermal subsystem coherence when removing 'bcmcmd show pvt' ASIC thermal sensor polling from NDK.

Please pair this submodule update with NDK >= 22.9.26 : NDK 22.9.26 PR is here: https://github.com/Azure/sonic-buildimage-msft/pull/316

Work item tracking
  • Microsoft ADO (number only):

How I did it

Made the necessary modifications to facilitate coherent temp sensor operations.

How to verify it

Verify that thermal subsystem operates normally via 'show platform temperature' command.

Please pair this submodule update with NDK >= 22.9.26 : NDK 22.9.26 PR is here: https://github.com/Azure/sonic-buildimage-msft/pull/316

Which release branch to backport (provide reason below if selected)

snider-nokia avatar Apr 04 '24 16:04 snider-nokia

@judyjoseph, Can you please review and merge? Thanks.

snider-nokia avatar Apr 04 '24 16:04 snider-nokia

@snider-nokia could you update the platform modules update Pr with the fix for https://github.com/Nokia-ION/ndk/issues/45 also, before we merge @rlhui f.y.i

judyjoseph avatar Apr 18 '24 16:04 judyjoseph

@snider-nokia could you update the platform modules update Pr with the fix for Nokia-ION/ndk#45 also, before we merge @rlhui f.y.i

Ok, all set now @judyjoseph.

snider-nokia avatar Apr 18 '24 16:04 snider-nokia

@snider-nokia , can you also ensure fixes like this are always pushed to public master as well? and its corresponding SDK also in msft repo Master? Thanks!

gechiang avatar Apr 18 '24 18:04 gechiang

@snider-nokia , can you also ensure fixes like this are always pushed to public master as well? and its corresponding SDK also in msft repo Master? Thanks!

Yes @gechiang, we are doing so. Some Nokia PMON changes are either master or 202205 specific, so we are handling individually (but keeping a close eye to ensure all changes are made at both branches). Also, we will discuss NDK at next appropriate meeting since the master and 202205 builds have now diverged there as well. Will keep you informed as to any/all decisions made in this regard.

snider-nokia avatar Apr 18 '24 18:04 snider-nokia