sonic-buildimage
sonic-buildimage copied to clipboard
Add dependency on tsa_enabled flag for BGP peer config during reload
Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload
Work item tracking
- Microsoft ADO (number only): 27171112
How I did it
Add dependency on tsa_enabled flag before peer configuration
How to verify it
- Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
- Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
Which release branch to backport (provide reason below if selected)
- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [x] 202205
- [x] 202211
- [x] 202305
Tested branch (Please provide the tested image version)
- [ ] 202205
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
@tjchadaga PR: https://github.com/sonic-net/sonic-buildimage/pull/18556 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18556 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9831823
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.
/azpw ms_conflict
"/azpw ms_conflict"
@tjchadaga PR: https://github.com/sonic-net/sonic-buildimage/pull/18556 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18556 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9887874
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.
/azpw ms_conflict
@StormLiangMS , @yxieca , can you help review this change? Thanks!
Hi @tjchadaga is there a known issue for this one? like routes are advertised out with TSA enabled on a reload? I'm asking this because 202305 piloting is almost done, should I hold the pilot for this one?
Hi @tjchadaga is there a known issue for this one? like routes are advertised out with TSA enabled on a reload? I'm asking this because 202305 piloting is almost done, should I hold the pilot for this one?
This was identified as a gap. No known issues due to this gap as of now.
Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-buildimage/pull/18721
Cherry-pick PR to 202305: https://github.com/sonic-net/sonic-buildimage/pull/18749