sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

[Nokia-7220-H3] Add support for NOKIA 7220 IXR-H3 platform

Open fzhou-nokia opened this issue 10 months ago • 13 comments

Why I did it

Add support for NOKIA 7220 IXR-H3:

Platform: x86_64-nokia_ixr7220_h3-r0
HwSKU: Nokia-IXR7220-H3
ASIC: Broadcom
Port Config: 32x400G + 2x10G
Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. Added module x86_64-nokia_ixr7220_h3-r0 ../device/nokia directory.
  2. Modified the platform/broadcom/one-image.mk to include NOKIA_IXR7220H3_PLATFORM_MODULE
  3. Modified the platform/broadcom/ platform-modules-nokia.mk to include NOKIA_IXR7220H3_PLATFORM_MODULE
  4. Add platform related directory ixr7220h3 in platform/Broadcom/sonic-platform-modules-nokia
  5. Modified related build scripts in platform/Broadcom/sonic-platform-modules-nokia/debian

How to verify it

  1. Make sure the sonic-buildimage is successful
  2. Run this image on x86_64-nokia_ixr7220_h3-r0 and verify all dockers are up and test basic commands like: o show version o show platform summary o show platform syseeprom o show platform fan o show platform psustatus o show platform firmware status o show platform temperature o sudo show system-health detail o show interface status
  3. Run OC test, for T0/T1 topology and have 100% pass on platform.
  4. Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly.

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111
  • [ ] 202205
  • [ ] 202211
  • [ ] 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

fzhou-nokia avatar Mar 28 '24 15:03 fzhou-nokia

@Pavan-Nokia @jon-nokia @mlok-nokia Please help review

fzhou-nokia avatar Mar 28 '24 19:03 fzhou-nokia

/azpw ms_conflict

liushilongbuaa avatar Apr 01 '24 10:04 liushilongbuaa

@StormLiangMS,@liushilongbuaa PR: https://github.com/sonic-net/sonic-buildimage/pull/18497 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18497 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9811366
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

mssonicbld avatar Apr 01 '24 10:04 mssonicbld

@StormLiangMS,@liushilongbuaa PR: #18497 is conflict with MS internal repoPlease push fix commit to sonicbld/precheck/head/18497 and approvehttps://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9811366After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

@liushilongbuaa @StormLiangMS Can you please take a look at this

Pavan-Nokia avatar Apr 03 '24 14:04 Pavan-Nokia

/azpw ms_conflict

liushilongbuaa avatar Apr 07 '24 08:04 liushilongbuaa

@StormLiangMS,@liushilongbuaa PR: https://github.com/sonic-net/sonic-buildimage/pull/18497 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18497 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9852302
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

mssonicbld avatar Apr 07 '24 08:04 mssonicbld

/azpw ms_conflict

liushilongbuaa avatar Apr 07 '24 09:04 liushilongbuaa

@liushilongbuaa @mssonicbld How can we help resolve this "internal conflict" issue and get this PR merged.

Pavan-Nokia avatar Apr 15 '24 13:04 Pavan-Nokia

@liushilongbuaa @mssonicbld How can we help resolve this "internal conflict" issue and get this PR merged.

It is resolved last week.

liushilongbuaa avatar Apr 16 '24 05:04 liushilongbuaa

@liushilongbuaa @mssonicbld How can we help resolve this "internal conflict" issue and get this PR merged.

It is resolved last week.

I still see that the corresponding PR check is in pending state and has not completed. Do you recommend we restart the checks?

Pavan-Nokia avatar Apr 16 '24 12:04 Pavan-Nokia

/azpw run Azure.sonic-buildimage

fzhou-nokia avatar Apr 16 '24 13:04 fzhou-nokia

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Apr 16 '24 13:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 16 '24 13:04 azure-pipelines[bot]

/azpw run Azure.sonic-buildimage

fzhou-nokia avatar Apr 16 '24 20:04 fzhou-nokia

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Apr 16 '24 20:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 16 '24 20:04 azure-pipelines[bot]

/azpw run Azure.sonic-buildimage

fzhou-nokia avatar Apr 18 '24 12:04 fzhou-nokia

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Apr 18 '24 12:04 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 18 '24 12:04 azure-pipelines[bot]

Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly.

Why you state that you tested on 7250?

Blueve avatar Apr 22 '24 13:04 Blueve

Run this image on x86_64-nokia_ixr7250e_sup-r0 and x86_64-nokia_ixr7250e_36x400g-r0, make sure all functions run correctly.

Why you state that you tested on 7250?

The H3 and 7250 share build files, so we have tested and made sure that our changes have not caused any regression to already existing platforms.

fzhou-nokia avatar Apr 22 '24 13:04 fzhou-nokia

@Blueve @yxieca Please help merge

Pavan-Nokia avatar May 06 '24 12:05 Pavan-Nokia

@prgeor can you help review this PR?

yxieca avatar May 13 '24 17:05 yxieca

@liushilongbuaa After we rebased the PR to latest Master the internal conflict (ms_conflict) has appeared again. Could you please help resolve.

Pavan-Nokia avatar May 17 '24 17:05 Pavan-Nokia

@liushilongbuaa After we rebased the PR to latest Master the internal conflict (ms_conflict) has appeared again. Could you please help resolve.

We are fixing the conflict. It still needs about 12 hours for the automation.

liushilongbuaa avatar May 20 '24 07:05 liushilongbuaa

@liushilongbuaa After we rebased the PR to latest Master the internal conflict (ms_conflict) has appeared again. Could you please help resolve.

We are fixing the conflict. It still needs about 12 hours for the automation.

@liushilongbuaa Thank you for your help with this. Are we all set to retry the PR checks?

Pavan-Nokia avatar May 21 '24 12:05 Pavan-Nokia

/azpw ms_conflict

liushilongbuaa avatar May 22 '24 03:05 liushilongbuaa

@yxieca Please help merge Thank you

Pavan-Nokia avatar May 22 '24 12:05 Pavan-Nokia