sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

Add LDAP feature support

Open davidpil2002 opened this issue 2 years ago • 10 comments
trafficstars

Why I did it

To support LDAP feature

Work item tracking
  • Microsoft ADO (number only):

How I did it

Similar to Radius/Tacacs authentication methods, the SONiC device is the LDAP client. Installed the Debian LDAP packages related to making SONiC able to function as an LDAP client.

More description in the following HLD: https://github.com/sonic-net/SONiC/pull/1487

How to verify it

Do LDAP configuration according to the HLD, then connect to the SONiC switch by using a user that exists in your LDAP server.

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111
  • [ ] 202205
  • [ ] 202211
  • [ ] 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

YANG Schema can be found attached in the HLD as well.

A picture of a cute animal (not mandatory but encouraged)

davidpil2002 avatar Oct 23 '23 13:10 davidpil2002

@lguohan who should review and provide feedback?

liat-grozovik avatar Dec 14 '23 09:12 liat-grozovik

@a-barboza Could you also help review this PR?

qiluo-msft avatar Dec 15 '23 00:12 qiluo-msft

yang-model tests are missing for LDAP, please add the same.

shdasari avatar Dec 18 '23 09:12 shdasari

error look not related to the new code. rerunning: /azpw run Azure.sonic-buildimage

davidpil2002 avatar Dec 27 '23 06:12 davidpil2002

/azpw run Azure.sonic-buildimage

davidpil2002 avatar Dec 27 '23 06:12 davidpil2002

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Dec 27 '23 06:12 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 27 '23 06:12 azure-pipelines[bot]

yang-model tests are missing for LDAP, please add the same.

DONE

davidpil2002 avatar Dec 27 '23 06:12 davidpil2002

All comments was answered, pls can you re-review/approve? @shdasari @asha-behera @a-barboza @madhupalu

davidpil2002 avatar Dec 27 '23 06:12 davidpil2002

@a-barboza , could you please review? I saw you did HLD review as well

fastiuk avatar Jan 29 '24 12:01 fastiuk

/azpw run Azure.sonic-buildimage

liat-grozovik avatar May 06 '24 06:05 liat-grozovik