sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

[containercfgd] Add containercfgd and syslog rate limit configuration support

Open Junchao-Mellanox opened this issue 2 years ago • 21 comments

HLD: https://github.com/sonic-net/SONiC/pull/1049

Why I did it

Add a containercfgd to handler container side CONFIG DB changes

How I did it

  1. add a daemon containercfgd to run for each containers
  2. add syslog handler to handle syslog rate limit config change

How to verify it

unit test

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111
  • [ ] 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Junchao-Mellanox avatar Oct 25 '22 14:10 Junchao-Mellanox

Build issue pending on PR https://github.com/sonic-net/sonic-buildimage/pull/12510

Junchao-Mellanox avatar Oct 26 '22 10:10 Junchao-Mellanox

/azp run Azure.sonic-buildimage

liat-grozovik avatar Oct 30 '22 07:10 liat-grozovik

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 30 '22 07:10 azure-pipelines[bot]

/azpw run Azure.sonic-buildimag

Junchao-Mellanox avatar Oct 31 '22 01:10 Junchao-Mellanox

/AzurePipelines run Azure.sonic-buildimag

mssonicbld avatar Oct 31 '22 01:10 mssonicbld

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Oct 31 '22 01:10 azure-pipelines[bot]

/AzurePipelines run Azure.sonic-buildimag

liushilongbuaa avatar Oct 31 '22 05:10 liushilongbuaa

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Oct 31 '22 05:10 azure-pipelines[bot]

/azprun Azure.sonic-buildimage

liushilongbuaa avatar Oct 31 '22 12:10 liushilongbuaa

/azp run Azure.sonic-buildimage

liushilongbuaa avatar Oct 31 '22 12:10 liushilongbuaa

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 31 '22 12:10 azure-pipelines[bot]

/azpw run Azure.sonic-buildimage

Junchao-Mellanox avatar Nov 02 '22 02:11 Junchao-Mellanox

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Nov 02 '22 02:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 02 '22 02:11 azure-pipelines[bot]

/azpw run Azure.sonic-buildimage

Junchao-Mellanox avatar Nov 08 '22 01:11 Junchao-Mellanox

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Nov 08 '22 01:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 08 '22 01:11 azure-pipelines[bot]

/azpw run Azure.sonic-buildimage

Junchao-Mellanox avatar Nov 11 '22 06:11 Junchao-Mellanox

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Nov 11 '22 06:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 11 '22 06:11 azure-pipelines[bot]

Hi @mkeda, I have fixed/replied all comments. Would you please review the new changes?

Junchao-Mellanox avatar Nov 11 '22 08:11 Junchao-Mellanox

/azpw run Azure.sonic-buildimage

Junchao-Mellanox avatar Nov 14 '22 01:11 Junchao-Mellanox

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Nov 14 '22 01:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 14 '22 01:11 azure-pipelines[bot]

/AzurePipelines run Azure.sonic-buildimage

yejianquan avatar Nov 15 '22 02:11 yejianquan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 15 '22 02:11 azure-pipelines[bot]

/azpw run Azure.sonic-buildimage

Junchao-Mellanox avatar Nov 16 '22 02:11 Junchao-Mellanox

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Nov 16 '22 02:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 16 '22 02:11 azure-pipelines[bot]

Hi @saiarcot895, could you please kindly help review this?

Junchao-Mellanox avatar Dec 05 '22 05:12 Junchao-Mellanox