sonic-buildimage icon indicating copy to clipboard operation
sonic-buildimage copied to clipboard

add Tunnel yang model

Open Ndancejic opened this issue 2 years ago • 7 comments

Signed-off-by: Nikola Dancejic [email protected]

Why I did it

Add yang model for TUNNEL config

How I did it

created sonic-tunnel.yang file and tests

How to verify it

make target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl

Which release branch to backport (provide reason below if selected)

  • [ ] 201811
  • [ ] 201911
  • [ ] 202006
  • [ ] 202012
  • [ ] 202106
  • [ ] 202111
  • [ ] 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#tunnel

A picture of a cute animal (not mandatory but encouraged)

Gizmo

Ndancejic avatar Sep 30 '22 01:09 Ndancejic

@praveen-li will add comments. @qiluo-msft will check the configuration part.

zhangyanzhao avatar Oct 06 '22 17:10 zhangyanzhao

@Ndancejic can you please help to address the comments? Thanks.

zhangyanzhao avatar Oct 13 '22 17:10 zhangyanzhao

@praveen-li @qiluo-msft I had a few questions on some of your comments

Ndancejic avatar Oct 25 '22 21:10 Ndancejic

why do you update submodule for frr?

ganglyu avatar Nov 03 '22 03:11 ganglyu

My mistake, it slipped past my diff. I'll update that

Ndancejic avatar Nov 03 '22 16:11 Ndancejic

@Ndancejic can you please help to address the comments? Thanks.

zhangyanzhao avatar Nov 03 '22 17:11 zhangyanzhao

@Ndancejic Some unit tests failed, please let me know if you need any help.

ganglyu avatar Nov 11 '22 01:11 ganglyu

@Ndancejic , could you please check the failures?

prsunny avatar Nov 29 '22 13:11 prsunny

@Ndancejic please help to address the build failure. Thanks.

zhangyanzhao avatar Dec 08 '22 18:12 zhangyanzhao

Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild

Ndancejic avatar Dec 12 '22 21:12 Ndancejic

Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild

sonic-config-engine will run yang validation for generated config_db, and it seems that test_minigraph_tunnel_table can't pass yang validation.

ganglyu avatar Dec 12 '22 23:12 ganglyu

Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild

sonic-config-engine will run yang validation for generated config_db, and it seems that test_minigraph_tunnel_table can't pass yang validation.

I can see the issue now, looks like it's because src/sonic-config-engine/tests/simple-sample-graph-case-remap-enabled.xml is configured with DecapDscpToTcMap="AZURE_TUNNEL" DecapTcToPgMap="AZURE_TUNNEL" EncapTcToQueueMap="AZURE_TUNNEL" EncapTcToDscpMap="AZURE_TUNNEL" However there is no AZURE_TUNNEL qos map.

Ndancejic avatar Dec 12 '22 23:12 Ndancejic

Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild

sonic-config-engine will run yang validation for generated config_db, and it seems that test_minigraph_tunnel_table can't pass yang validation.

I can see the issue now, looks like it's because src/sonic-config-engine/tests/simple-sample-graph-case-remap-enabled.xml is configured with DecapDscpToTcMap="AZURE_TUNNEL" DecapTcToPgMap="AZURE_TUNNEL" EncapTcToQueueMap="AZURE_TUNNEL" EncapTcToDscpMap="AZURE_TUNNEL" However there is no AZURE_TUNNEL qos map.

Thanks! Would you please fix this unit test?

ganglyu avatar Dec 13 '22 00:12 ganglyu