sonic-buildimage
sonic-buildimage copied to clipboard
add Tunnel yang model
Signed-off-by: Nikola Dancejic [email protected]
Why I did it
Add yang model for TUNNEL config
How I did it
created sonic-tunnel.yang file and tests
How to verify it
make target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
Which release branch to backport (provide reason below if selected)
- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#tunnel
A picture of a cute animal (not mandatory but encouraged)
@praveen-li will add comments. @qiluo-msft will check the configuration part.
@Ndancejic can you please help to address the comments? Thanks.
@praveen-li @qiluo-msft I had a few questions on some of your comments
why do you update submodule for frr?
My mistake, it slipped past my diff. I'll update that
@Ndancejic can you please help to address the comments? Thanks.
@Ndancejic Some unit tests failed, please let me know if you need any help.
@Ndancejic , could you please check the failures?
@Ndancejic please help to address the build failure. Thanks.
Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild
Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild
sonic-config-engine will run yang validation for generated config_db, and it seems that test_minigraph_tunnel_table can't pass yang validation.
Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild
sonic-config-engine will run yang validation for generated config_db, and it seems that test_minigraph_tunnel_table can't pass yang validation.
I can see the issue now, looks like it's because src/sonic-config-engine/tests/simple-sample-graph-case-remap-enabled.xml is configured with DecapDscpToTcMap="AZURE_TUNNEL" DecapTcToPgMap="AZURE_TUNNEL" EncapTcToQueueMap="AZURE_TUNNEL" EncapTcToDscpMap="AZURE_TUNNEL"
However there is no AZURE_TUNNEL qos map.
Rebased and cleaned up the commits a bit. I would appreciate a second look - edit: nvm I need to take another look at this :/ my build is still going through without an issue for some reason... I think I'll have to clean and rebuild
sonic-config-engine will run yang validation for generated config_db, and it seems that test_minigraph_tunnel_table can't pass yang validation.
I can see the issue now, looks like it's because src/sonic-config-engine/tests/simple-sample-graph-case-remap-enabled.xml is configured with
DecapDscpToTcMap="AZURE_TUNNEL" DecapTcToPgMap="AZURE_TUNNEL" EncapTcToQueueMap="AZURE_TUNNEL" EncapTcToDscpMap="AZURE_TUNNEL"
However there is no AZURE_TUNNEL qos map.
Thanks! Would you please fix this unit test?