SONiC icon indicating copy to clipboard operation
SONiC copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

Feature/add lacp rate

Open globaltrouble opened this issue 3 years ago • 11 comments

PR title state context
[swss/cfgmgr] teammgr configure lacp rate sonic-swss#2121 teammgr configure lacp rate teammgr configure lacp rate
add lacp_rate to portchanne add lacp_rate to portchanne add lacp_rate to portchanne

What I did

Make lacp_rate configurable for portchannel.

	Option specifying the rate in which we'll ask our link partner
	to transmit LACPDU packets in 802.3ad mode.  Possible values
	are:

	slow
		Request partner to transmit LACPDUs every 30 seconds

	fast
		Request partner to transmit LACPDUs every 1 second

	The default is slow.

Why I did it

In case of slow lacp_rate configuration link down will be detected in 60-90 seconds, it may be to long (for example for MCLAG high availability), in case of using --fast-rate=true link down will be detected in 2-3 seconds.

How I did it

  • add optional argument to config portchannel command, default=slow for backward compatibility. https://github.com/Azure/sonic-utilities/pull/2036
  • parse argument in teammgr and forward it to teamd https://github.com/Azure/sonic-swss/pull/2121
  • update docs (this PR)

How to verify it

Confgiure bond on other side, then configure portchannel and sniff the traffic from it.

config portchannel add PortChannel0001  --fast-rate=true
config portchannel member add PortChannel0001 Ethernet0
config interface ip add PortChannel0001  192.168.1.2/24
tcpdump -ne

globaltrouble avatar Jan 28 '22 14:01 globaltrouble

@stcheng could you please review it?

globaltrouble avatar Jan 31 '22 10:01 globaltrouble

Related PR's

  • https://github.com/Azure/sonic-swss/pull/2121
  • https://github.com/Azure/sonic-utilities/pull/2036

msosyak avatar Feb 16 '22 18:02 msosyak

Related PR's

@msosyak please have all the PRs in description section. Example:

https://github.com/Azure/SONiC/pull/909

nazariig avatar Apr 05 '22 10:04 nazariig

Related PR's

@msosyak please have all the PRs in description section. Example:

https://github.com/Azure/SONiC/pull/909

Unfortunately, I am not the author of PR, so I cant changes the descriotion

msosyak avatar Jul 13 '22 08:07 msosyak

Related PR's

@msosyak please have all the PRs in description section. Example:

https://github.com/Azure/SONiC/pull/909

Unfortunately, I am not the author of PR, so I cant changes the descriotion

Updated the description

globaltrouble avatar Jul 13 '22 09:07 globaltrouble

/easycla

msosyak avatar Aug 09 '22 09:08 msosyak

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: msosyak / name: Myron Sosyak (8f87358b50e1a4ec80277178518bde91aa1c8030)

linux-foundation-easycla[bot] avatar Aug 09 '22 09:08 linux-foundation-easycla[bot]

@qiluo-msft All related PR;'s are merged. Please help to merge this documentation update as well.

msosyak avatar Aug 15 '22 07:08 msosyak

@qiluo-msft @xumia @judyjoseph Please merge this PR

msosyak avatar Aug 29 '22 07:08 msosyak

Implementation is already merged. This PR is just an update for documentation. @nazariig Please review/approve @qiluo-msft Please merge

msosyak avatar Sep 13 '22 07:09 msosyak

Does this feature need to be added to the show interface portchannel?

twtseng-tim avatar Sep 28 '22 02:09 twtseng-tim