Switch Port Modes and VLAN CLI Enhancement

[ham-xa]

We have created an HLD for Switchport modes and enhancements to VLAN CLI.

Related PRs:

Repo	PR title	State
sonic-utilities	Switch Port Modes and VLAN CLI Enhancement

[ghost]

All CLA requirements met.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: ham-xa / name: Hamza Iqbal (ab74bb25dc6afe6d39581c609bdbd0ce6f09f732, 56dfc1484a22bea206c2adbef1b9fc448902a97c, f1ae3a61e0333fba1b709c2332a75379ca9dd8e3, 91d1d02e3d812053d29f6ba674160a8e6b69a2a9, 818f47ada90f443c7fe885f276afe95eca7a748a, 084c665b3a7b0ce1e0c8fc45185174de6c01d625, 22342c295a5b014c711b85bc6ea10203892503ed, 8f15f2f78c272c648e03dd998d12840abaefc2a0, cd6449a6a88cf51a9eb6d7c2fe44ebfe1ba63963, 06c99444d1199db6884a1bc8b56495320d308be8, db548e036dd8b44b774dabda95a46aa47fb0908e)
• :white_check_mark: login: ridahanif96 / name: Rida Hanif (add77889602182af112e9f98a9a2520a7362caef, 126842873201e617fabcc6ab3951ac1904979a18, 30d25cfcb6f299b84904d55e4b625489887557e9, cbb9ac5d93a02f99e426417e2894f992a228b324, 1a23c895b860fe37799de8c31a1eb158b298f3dd, 070434114f4d26a4974006cd85b7737e1465158a, 4bc8db6a59acf67f3375d90b51cbd0180066227d, 639c70a97bd7b238d1bc8e1d97f4c058efeb9f00, 5cb27f5756f6e653a4ec83240b8cf6a476466722, f5e79e7078a36f7ce76a72ccb348be2579619ab5, e40754d89dcd764a63c634fe24d6999a1b22c63f, 71cd865bd99b5fef1e9f8078d1ef884fa6d5bd13, 29847dfbbd7741d9bfaf171f1b1a5ca3ba8d7ee4, ad4596c42b193e86a85b313aa0bf6e171e2ca404, e92a38fe0f18cdb48933bcce2d5471f51c153e78, bf5990ef9b623317ef29c494755bc942be9ce3ad, 20560cde2f26395284b53c8b264387defa8a3b8a, 1c6dc80fc9c8a06dda123031427f64459487a460, f160a31c5165505e810f9b227f8e5ea01c1b25d8, f3f9a3a4de9001c0aecde9c84013f1a61f9a8150, f8be3c736a30f47d08152fafe6bda51cdb86ef69, 45ce3cb604bacc73fcc682b4397f50d53ade0813, 2c1731098098cacbacb96edb4d553aa23130dca5, b01f9e0152c908f3cfac2f9ddf5eb5f73cf50ea7, 586c33c4e1789cf4c2941d71a881a4697bd2c392, 063284d3d5de9644e4a6c4af68531cd160480d82, f59187d0f6f423a3168aa52ef8e05ff5cd5467de, afcfaf5a0e5bb04b702d6c49195dff927ca1b9ec, d4d57961400d8fc2e2bad176334239946c75ade4, 85dd22ef6cf46b63ca760533e41f9aa6596dd050, 940fc852da1814363e2d12092162138ba97bec16, ec7aa683b6442fba5510cf98df9b4c09b6442e1e, e5d73295836873e7717514892f5feb19e69a4be4, d85d84f130ae20e212f6d727d2c29d6b34d26cfd, 420236b50de8990e9d228f3f69275f0e1fb54ee6, 3a01728675b7f16bdf513d76c8f74f5bc3bdecae, e4efa7e54d161a09b0a702a162188f8e9ac21cec, 6bba6e6ad7ea7a889e90f4aed2280e651f27bc27, 5991d00b6634ea5c53e85847e0d2445fc1f7b1a7, 9f4409c82bea6c43a6092627a6a4051fe818432e, 5821261696b3ee189a4e67e3f1fe9f926971d219, daba4940bc6d5c6c6e182cf8b2b29ade16a08d60, 29d3b317c068c5fd8221f58db3906394c0bd2717, ae0c6d6eca7fc603a6272a8cfd98c5ec7bb40209, 60d952c056a25cb341752841103a572a5ba6a936, 873f410d16e44d0fae202c4b6706114b098b471a, ee1e145a7ee9b80f04f79d385da62984bde51caa, 3f33c3259320fe883143635a586a13ae3a935f19, 93655ac024e5945dc2c30ae6d850742180c69f28, ba83bc9b0906238d14339d39373a0eab4381f768, fc6fccadc7a3e121236940302093296e3f2538d7, bc027a8b11d13bf125e3ba9ea1a623dace701e68, f8476512fba2feb97bcaead25b43d2a0e3bab198, 854f2c05fb66097e0ae760f6c560106b2ca05544, c0110218ac6501a224e8679f4e9ec6b74ea233e4, 66ae8ab7600500b533b8b574380f53342da6dc6c, f768368b1bed9ae88edec279fbb241cdae883a11, 79d161d1a726f44fb6590e4764e37807d257b3ee, 3a1420fbdfeff77961f7e6939a430c30d33795c4)

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: ham-xa / name: Hamza Iqbal (ab74bb25dc6afe6d39581c609bdbd0ce6f09f732, 56dfc1484a22bea206c2adbef1b9fc448902a97c, f1ae3a61e0333fba1b709c2332a75379ca9dd8e3, 91d1d02e3d812053d29f6ba674160a8e6b69a2a9, 818f47ada90f443c7fe885f276afe95eca7a748a)

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: ham-xa / name: Hamza Iqbal (ab74bb25dc6afe6d39581c609bdbd0ce6f09f732, 56dfc1484a22bea206c2adbef1b9fc448902a97c, f1ae3a61e0333fba1b709c2332a75379ca9dd8e3, 91d1d02e3d812053d29f6ba674160a8e6b69a2a9, 818f47ada90f443c7fe885f276afe95eca7a748a)
• :white_check_mark: login: ridahanif96 / name: Rida Hanif (add77889602182af112e9f98a9a2520a7362caef)

[ridahanif96]

We have updated our HLD along with the code. @venkatmahalingam pls review.

[zhangyanzhao]

@venkatmahalingam can you please review this PR and approve if you are ok? Thanks.

[zhangyanzhao]

@venkatmahalingam can you please help to review this HLD and corresponding code PR? Thanks.

[venkatmahalingam]

@venkatmahalingam can you please help to review this HLD and corresponding code PR? Thanks.

Yes @zhangyanzhao, I have added my comments.

[zhangyanzhao]

@venkatmahalingam can you please approve this PR if all your comments have been addressed? Otherwise, can you please help to repaste your question? I am not quite clear what is open now.

[venkatmahalingam]

@venkatmahalingam can you please approve this PR if all your comments have been addressed? Otherwise, can you please help to repaste your question? I am not quite clear what is open now.

I don't think, we need 'mode' field in the PORT table.

Please check following in VLAN_MEMBER table, If the port is untagged to only one VLAN - Access mode If the port is untagged member to one VLAN and tagged member to one or more VLAN - Trunk mode If the port is not present in VLAN_MEMBER table - Routed mode

We can update the VLAN column of "show interface status" accordingly. IMO, adding 'mode' field in the PORT table is unnecessary.

[venkatmahalingam]

@prsunny @dgsudharsan Please review this HLD.

[ridahanif96]

@prsunny @dgsudharsan , Please review this HLD.

[venkatmahalingam]

@zhangyanzhao I think, we should quickly update the community in one of the Tuesday's call about this change as it affects the way we configure the VLAN configs on port/port-channel.

[zhangyanzhao]

re-discussed in sonic community meeting.

[rck-innovium]

The CONFIG_DB changes are missing in this doc.

https://github.com/sonic-net/SONiC/blob/master/doc/hld_template.md#config-db-enhancements

[zhangyanzhao]

@gechiang @venkatmahalingam will review and sign-off.

[zhangyanzhao]

Target 202305 release.

[lguohan]

feedbacks:

1. state transition graph between access/trunk mode
2. db migrator to address backward compatibility
3. default vlan mode should be trunk
4. sonic-mgmt tests needs to modified accordingly

[zhangyanzhao]

community re-reviewed this HLD on 2/7/2023 and recording is https://zoom.us/rec/share/1RIEGIIRn2O3ltEUDUVmyrze-7QSKDORTz1CL9JZlijh_sShvIOzkoIKXXIx6J0T.JZgQNK8ky0a0HhFd

[zhangyanzhao]

@ham-xa can you please help to address the review comments? @venkatmahalingam @gechiang are the registered reviewers for this PR.

[ridahanif96]

@zhangyanzhao we are on it and updating HLD as per reviewers' suggestions/comments along with sonic-mgmt test cases.

[ridahanif96]

The CONFIG_DB changes are missing in this doc.

https://github.com/sonic-net/SONiC/blob/master/doc/hld_template.md#config-db-enhancements

Done

[ridahanif96]

feedbacks:

1. state transition graph between access/trunk mode
2. db migrator to address backward compatibility
3. default vlan mode should be trunk
4. sonic-mgmt tests needs to modified accordingly

Updated as per suggestions and modified sonic-mgmt testcases as well.

[ridahanif96]

We have updated our HLD as per suggestions/concerns. @venkatmahalingam @gechiang Please Review. Thanks

[zhangyanzhao]

defer to 202305 release to continue

[ridahanif96]

defer to 202305 release to continue

Part of 202305, we are already in HLD & code review with the reviewers, will finalize this by tomorrow.

[ridahanif96]

We have added detailed examples for Switchport Modes as per suggestion/concerns. @gechiang @venkatmahalingam please review.

[ridahanif96]

@gechiang can you please review and merge this PR. Target is 202305

[ridahanif96]

@zhangyanzhao can you please merge this PR, Thanks