SONiC icon indicating copy to clipboard operation
SONiC copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[Logrotate] Add logrotate feature HLD

Open fastiuk opened this issue 1 year ago • 10 comments
trafficstars

This document provides general information about log rotate implementation in SONiC

The scope of this document is to cover definition, design and implementation of SONiC log rotate feature and related CLI.

PR title state context
[Logrotate] Add log rotate configuration GitHub issue/pull request detail GitHub pull request check contexts
[Logrotate] Update log rotate configuration via ConfigDB GitHub issue/pull request detail GitHub pull request check contexts
[Logrotate] Add log rotate configuration tables GitHub issue/pull request detail GitHub pull request check contexts
[Logrotate] Add config and show commands GitHub issue/pull request detail GitHub pull request check contexts

fastiuk avatar Apr 27 '24 22:04 fastiuk

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: fastiuk / name: Yevhen Fastiuk (d9c74cbddea332a796801b89b2c2409f86b937cd, 5ff7810e3e6743467abd5d5ad89327d97b147e46, 0a8a9ad631a252b9d22007f26984e33d7396e5be, af5b9057b4b2b24dc99153adb63bbe5123a84bab, b81d5b9c57c2896f3fcfccb584d4ce28ccbfb629)

linux-foundation-easycla[bot] avatar Apr 27 '24 22:04 linux-foundation-easycla[bot]

HLD is reviewed in community on 5/14/2024

zhangyanzhao avatar May 14 '24 15:05 zhangyanzhao

call for reviewers, please leave your comments if you want to be a reviewer of this HLD. Thanks.

zhangyanzhao avatar May 14 '24 15:05 zhangyanzhao

community review recording https://zoom.us/rec/share/pxggDmJPYuO2cbCd3OALS8z-rce-qXfZ_-zX6AU7s1xWyIi2oSiw8eJJ_rBU0PMW.wlH1D2euCp9OJ-vS

zhangyanzhao avatar May 15 '24 05:05 zhangyanzhao

@saiarcot895 could you review?

prgeor avatar Jun 11 '24 06:06 prgeor

we need to expedite this review. the PRs are ready for more than 3 months @zhangyanzhao if not additional feedback, the PR should be merged by end of this week.

liat-grozovik avatar Jul 09 '24 16:07 liat-grozovik

@liat-grozovik can we merge this? No further comments were provided.

fastiuk avatar Aug 06 '24 11:08 fastiuk

@saiarcot895 all comments were addressed, can I get an approval?

fastiuk avatar Aug 28 '24 09:08 fastiuk

@saiarcot895 all comments were addressed, can I get an approval?

fastiuk avatar Oct 21 '24 12:10 fastiuk

@saiarcot895 all comments were addressed, can I get an approval?

fastiuk avatar Nov 04 '24 17:11 fastiuk

@saiarcot895 all comments were addressed, can I get an approval?

fastiuk avatar Dec 02 '24 17:12 fastiuk

@fastiuk There's an open discussion item above.

saiarcot895 avatar Dec 02 '24 17:12 saiarcot895

PRs are not merged, move to backlog

zhangyanzhao avatar Dec 10 '24 05:12 zhangyanzhao

@zhangyanzhao i disagree The document was shared along time ago and qa reviewed 2 out of the PRs were already merged You cannot just put things in the backlog The maintainers need to be responsive and allow changes to get in

I will work with the author and the reviewers the complete and I do expect that to be in 202411

@fastiuk please check what is still not approved form PRs pov and make sure the checkers are passing for the missing PRs

liat-grozovik avatar Dec 10 '24 06:12 liat-grozovik