SONiC icon indicating copy to clipboard operation
SONiC copied to clipboard

Adding the HLD for SONiC reset local users' passwords

Open azmy98 opened this issue 1 year ago • 10 comments

This document provides general information about reset local users' passwords during init implementation in SONiC

The scope of this document is to cover definition, design and implementation of SONiC reset local users' passwords during init feature.

Submodule PR Title Status
sonic-buildimage Feature YANG Model & SystemD service GitHub issue/pull request detail
sonic-utilities CLI commands GitHub issue/pull request detail
sonic-swss-common Config DB Schema GitHub issue/pull request detail
sonic-platform-common Feature Base Class Implementation GitHub issue/pull request detail

azmy98 avatar Jan 04 '24 10:01 azmy98

community review recording https://zoom.us/rec/share/Mmpq0viHcC2J7QQnHzszlZX4iPR7VqYnXj4u3r7Rzavs4nPG1SImgBb2FK-fL--K.12p00bKsBDn_RCO9

zhangyanzhao avatar Jan 09 '24 16:01 zhangyanzhao

This feature should be turned off by default.

zhangyanzhao avatar Jan 09 '24 16:01 zhangyanzhao

@liuh-80 Could you help review?

qiluo-msft avatar Apr 09 '24 17:04 qiluo-msft

@azmy98 when do you expect to share the code PRs?

liat-grozovik avatar Apr 17 '24 10:04 liat-grozovik

it was decided to remove this HLD for SONiC. PR is closed.

liat-grozovik avatar Apr 25 '24 15:04 liat-grozovik

I see no further comments and all seems to be addressed. @liuh-80 @venkatmahalingam FYI the PR is going to be merged soon.

Appreciate if you can also review the code PRs and provide your feedback.

liat-grozovik avatar May 22 '24 07:05 liat-grozovik

@venkatmahalingam would you mind to provide code PR review feedback as well?

liat-grozovik avatar May 22 '24 07:05 liat-grozovik

YANG PR will be reviewed in the YANG workgroup meeting. Other PR review is on-going.

zhangyanzhao avatar May 22 '24 16:05 zhangyanzhao

@liat-grozovik will bring this to TSC to get guidance how to handle such PR which needs 2nd reviewers.

zhangyanzhao avatar May 22 '24 16:05 zhangyanzhao

@liat-grozovik / @zhangyanzhao can we merge this PR?

fastiuk avatar Aug 13 '24 22:08 fastiuk