SONiC icon indicating copy to clipboard operation
SONiC copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

High-level Design of Storage Monitoring Daemon

Open ashwnsri opened this issue 2 years ago • 5 comments

This PR is intended to harden the high-level design of a newly-proposed Storage monitoring daemon.

Repo PR Title State
sonic-platform-common Support for several static and dynamic attrs as part of storagemnd implementation Review
sonic-platform-daemons Implementation of a Monitoring Daemon for storage devices in SONiC switches Review
sonic-buildimage A bind-mount from pmon container to host directory Draft
sonic-utilities Sync FS I/O reads/writes just before OS-level reboot Draft

[List of changes]

  • Added new directory for storagemond
  • Added images directory within storagemond directory
  • Added HLD MD file for storagemond

Signed-off-by: Ashwin Srinivasan [email protected]

ashwnsri avatar Sep 20 '23 22:09 ashwnsri

@assrinivasan please add the PR link to the description of this PR

prgeor avatar Feb 09 '24 19:02 prgeor

@assrinivasan please add the PR link to the description of this PR

done.

ashwnsri avatar Feb 09 '24 20:02 ashwnsri

@assrinivasan Can you draw a class inheritance diagram to show StorageDevices, SSdBase, SsdUtil, EmmcUtil, etc

Done in latest commit

ashwnsri avatar Feb 09 '24 21:02 ashwnsri

Community review recording https://zoom.us/rec/share/_2364XvdG1EZbkV2aKq7zwXwu2cm-lCXoDQJbHbwEhgqqwCS9rHGGJiqJYFVWmWC.feJIB4_RHzx2EevX

zhangyanzhao avatar Feb 27 '24 17:02 zhangyanzhao

Comments from community review:

  1. Handle upgrade & schema change scenario as it pertains to fsstats files in the bind mount directory (protobuf)
  2. Guard against infinite size increase to the fsstats file by changing the file format to JSON

ashwnsri avatar Feb 27 '24 23:02 ashwnsri

@assrinivasan the core algorithm for updating the stats is pending. the 202405 branch where this feature needs to be in will be created by 05/31 and porting this thereafter will be difficult. FYI

prgeor avatar Apr 23 '24 20:04 prgeor

@assrinivasan the core algorithm for updating the stats is pending. the 202405 branch where this feature needs to be in will be created by 05/31 and porting this thereafter will be difficult. FYI

@assrinivasan this include HLD+Code PRs as well

prgeor avatar Apr 23 '24 20:04 prgeor

@assrinivasan the core algorithm for updating the stats is pending. the 202405 branch where this feature needs to be in will be created by 05/31 and porting this thereafter will be difficult. FYI

Hi @prgeor , this is added in the latest commit. Thanks!

ashwnsri avatar Apr 26 '24 22:04 ashwnsri

@prgeor can you please double check if the 1 open code PR can be merged today? Otherwise, we will move to backlog for future release.

zhangyanzhao avatar Jun 04 '24 17:06 zhangyanzhao

Hi @zhangyanzhao -- all PRs have been merged.

ashwnsri avatar Jun 05 '24 05:06 ashwnsri