SONiC
SONiC copied to clipboard
sonic-net
Multiple Spanning Tree Protocol (MSTP) HLD
This document describes the design details for IEEE 802.1s - Multiple Spanning Tree Protocol (MSTP) support in SONiC.
SONiC community review recording https://zoom.us/rec/share/3XxqJ20eag07iK0x7T_4YqBq6jhbyWXGjpk72AvHL35peWSOXZ04w_ZQjGlwXJbM.0DPyXu03R_bS0Gry
@lguohan , Please find following are unmerged PRs of PVST, that needs to merged for MSTP: SWSS: https://github.com/sonic-net/sonic-swss/pull/1058 Utilities: https://github.com/sonic-net/sonic-utilities/pull/648 Buildimage: https://github.com/sonic-net/sonic-buildimage/pull/3463
@hamnarauf can you please help to add the code PR list in this HLD? Thanks.
@hamnarauf can you please help to add the code PR list in this HLD? Thanks.
Hi @zhangyanzhao , Hamna is no longer assignee on this feature. Please consider @Wajahat as assignee on this from now onward. We are working on MSTP code and waiting for @adyeung help in unmereged code PR of PVST. Thanks!
@ridahanif96 can you please help to add the code PRs to this HLD by referring to #806 ? Thanks!
@ridahanif96 can you please help to add the code PRs to this HLD by referring to #806 ? Thanks!
@zhangyanzhao thanks for help! This feature has been deferred for next release.
@lguohan , Please find following are unmerged PRs of PVST, that needs to merged for MSTP: SWSS: sonic-net/sonic-swss#1058 Utilities: sonic-net/sonic-utilities#648 Buildimage: sonic-net/sonic-buildimage#3463
@adyeung Hi Adam, Can you please help with these unmerged PRs of PVST, Thanks!
Hi @divyachandralekha , do you have more suggestions on the design? if no can you please help approve this PR. Also we can discuss offline for PVST code PRs and our workflows for bringing STP/PVST/MSTP to SONiC
@ridahanif96 The earlier PVST code PRs will be updated and reposted in the next community release
@ridahanif96 The earlier PVST code PRs will be updated and reposted in the next community release
@adyeung thanks Adam!, till then it would be great if we also finalize this design and merge this.
@rck-innovium Hi Ravi, can you please help review this design. As per suggestion earlier in SAI community we had updated SAI Modification for MSTP control packets.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: hamnarauf / name: Hamna Rauf (064ae6ef71283c67dd7fc30c37ca21f81ca0bd4f, a19b757b65894116ff68cc38faeff51c33dde9ce, e9c22c3acefe807c6c83b71bab64360272fe2ecd, 6370e96e6acff337545ac8765cb233bebab79148, 865134a160addf950767d39da4ab90c22af57e38, 07c9f56d3e8207fcaf0f8770dd9e7c3edad2fdc6, 6bf70a3679ac1c4a763164e91b8748df8c95241a, 3f584ba8272daaa2853f20aa946769eeeb71d976, b789c19a6b965b1633200ab710468f049c510a6f)
- :white_check_mark: login: ridahanif96 / name: Rida Hanif (c79939226251a24ad5d467072e706cb34e1b0d91, 8ebdc149735a376369debe09f8389a6e0958010c, 6c3db77a68eb16a586207c88e83ecb78c86dda68, cb56cb6875db2709269c1742ac8efa94940da379, 22d5811dfca48d2e809402b0b7f2754460e0561f)
- :white_check_mark: login: divyachandralekha / name: Divya Kumaran Chandralekha (387f5b275e1af5c01f3a11799232291fb93ae740)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Is the plan to merge the code for both PVST and MSTP together for the community sonic or would one be merged before?
Is the plan to merge the code for both PVST and MSTP together for the community sonic or would one be merged before?
No, As discussed in PENS WG , we will only provide MSTP for the community in this release ,we will not be looking into PVST code merged.
@madhupalu , @praveenraja1 , @sutharsansr @adyeung @zhangyanzhao , As per our Discussion in PENS WG, New Updated Design is ready for review. Please consider Multiple Spanning Tree Protocol (MSTP) Updated HLD from onwards. Please help review the new design.
This PR will be closed to avoid confusion.
Closing this PR, revised HLD in the following submission
https://github.com/sonic-net/SONiC/pull/1761