SONiC icon indicating copy to clipboard operation
SONiC copied to clipboard

Generic Hash HLD

Open nazariig opened this issue 2 years ago • 2 comments

nazariig avatar Oct 24 '22 10:10 nazariig

Does the hash field configuration apply for original incoming packets of the switch or final modified packets of the switch?

rlhui avatar Oct 25 '22 15:10 rlhui

please look into how we can add api to expose what fields are actually being used in the hash by the switch.

rlhui avatar Oct 25 '22 16:10 rlhui

@prsunny @rlhui kindly reminder to review. the follow up HLD review with the community is set for 12/06. Appreciate if you can review it following the prev review feedback

liat-grozovik avatar Dec 05 '22 08:12 liat-grozovik

Does the hash field configuration apply for original incoming packets of the switch or final modified packets of the switch?

@rlhui to the original packets only - configuration is tunnel agnostic according to the SAI behavioral model

nazariig avatar Dec 05 '22 14:12 nazariig

please look into how we can add api to expose what fields are actually being used in the hash by the switch.

@rlhui done

nazariig avatar Dec 05 '22 14:12 nazariig

reviewed in Sonic community meeting.

zhangyanzhao avatar Dec 06 '22 16:12 zhangyanzhao

@rlhui and @prsunny Following the community review it was agreed to move forward with this HLD and have a second phase with new SAI API. As of that, if any additional feedback to this HLD is available please send the sooner the better. Otherwise we will assume all is agreed and we will merge this HLD in the next few days.

liat-grozovik avatar Dec 13 '22 09:12 liat-grozovik

@zhangyanzhao the HLD was reviewed and then we had a follow up. Code PRs are ready. We should move forward with approval and merge as no feedback provided since the last review which was about month ago.

liat-grozovik avatar Jan 17 '23 15:01 liat-grozovik

The feature and its current content is expected to be in 202305 and under discussion if to take into 202211 as originally aimed.

liat-grozovik avatar Jan 29 '23 09:01 liat-grozovik