SONiC
SONiC copied to clipboard
Add time-based ACL High Level Design document
This is new feature: time-based ACL HLD. The related code PR is: https://github.com/sonic-net/sonic-utilities/pull/2354 https://github.com/sonic-net/sonic-buildimage/pull/11989
Comments from community:
- Support different format for start_time and end_time (might be we can do this in cli's implementation )
- Add optional field to existing acl rule instead create new table
- Cli to create time_based acl rule based relative semantic such as
add acl rule *** expire in 2hrs
which will use system current time as start automatically then no time sync consideration here - For general use case, if user want to provide absolute time, the time sync is required
- Who can cleanup the config_db? In current HLD, stale rule will be removed by mgr after it expired, however it will change config_db. We suppose sonic will not touch/change config db since it is the system that consuming the config_db. But left stale rules in config_db can be also lead some unnecessary overhead, may be we can provide an option to user and let user to decide if remove the stale rule automatically?