sonic-net
S3IP sysfs specification and S3IP sysfs framework HLD
SONiC is designed to be portable to a variety of network devices. Many devices share the same ASIC platform and only differ in device-specific hardware components, such as PSUs, fan modules, and environment sensors. Currently, ODM vendor provides drivers to expose the device-specific hardware through sysfs, allowing SONiC to communicate with them, as described in the Porting Guide. However, many inefficient porting works are still required for SONiC developers due to different drivers from different devices.
The S3IP sysfs specification defines a unified interface to access peripheral hardware on devices from different vendors, making it easier for SONiC to support different devices and platforms.
| Repo | PR title | State |
|---|---|---|
| sonic-buildimage | Two platforms supporting S3IP SYSFS (TCS8400, TCS9400) |  |
| sonic-buildimage | S3IP sysfs framework and demo |  |
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: tianshangfei (40fb633e7adad36f7f7bdd32e0e23abc76741714, 2f402fd640c83712925186e6a983a20fc5162721, 48a2c4f14118fab12f3a548416d52deb4b2258e9, 9a0e85caf9707097457e5e5c641bd10074063d7d, 6b24d2d0888a1407533d1adc34ac9af8923887f7, ba1d192e686e5ffd44a63f7af53aa57097c1b065)
- :white_check_mark: login: lihuay / name: Lihua Yuan (d8486e27e52c2e24f8d4ee240e504e466eb2b0e8)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Minor spelling/punctuation errors, otherwise looks good!
I Receive notification that "SONIC202211 branch will be forked by end of this month per schedule". I have submitted my code PR for some time, and haven't received any review comments at present. I hope the 202211 version supports this feature, please help speed up the review process, thank you
LGTM, thanks!
I modified it once before, and found that some alarms were not introduced by our modification, and some alarms were considered to be false positives by tool inspection. I will modify it again. Does LGTM have to be cleared before PR can be merged?
I modified it once before, and found that some alarms were not introduced by our modification, and some alarms were considered to be false positives by tool inspection. I will modify it again. Does LGTM have to be cleared before PR can be merged?
I'm not sure I fully understand your question. LGTM = "Looks good to me," sorry if my use of this acronym was ambiguous. I am OK with the PR.
GitHub is saying someone with write access needs to approve, in other words a repo maintainer.
I modified it once before, and found that some alarms were not introduced by our modification, and some alarms were considered to be false positives by tool inspection. I will modify it again. Does LGTM have to be cleared before PR can be merged?
I'm not sure I fully understand your question. LGTM = "Looks good to me," sorry if my use of this acronym was ambiguous. I am OK with the PR.
GitHub is saying someone with write access needs to approve, in other words a repo maintainer.
OK，github's code review tool is also called LGTM （refer to LGTM.com）, So there was a misunderstanding. How can I speed up the merge process？ thanks.
@lguohan I have submitted the code PR for some time, and no further comments were received. I hope the 202211 version supports this feature, Please help to review it. Thanks
@lguohan can you please help to check if this PR can be merged? Reviewers have approved and build passed. Thanks.
@lguohan , all the code PRs are merged, can you please check if this PR can be merged as well? Thanks.
@tianshangfei can you please rebase this PR? Seems like the info is out of sync with master branch
@tianshangfei can you please rebase this PR? Seems like the info is out of sync with master branch Ok, PR is synchronized with master branch
@lguohan can you please help to review and merge this HLD PR? The code PRs have been merged.