scan-gradle-plugin icon indicating copy to clipboard operation
scan-gradle-plugin copied to clipboard
verified publisher icon sonatype-nexus-community

#147 Drop usage of shadow plugin

Open shaikhu opened this issue 2 years ago • 2 comments

Plugin is no longer deployed as an uber jar. This PR drops all usage/configuration of the shadown plugin.

Unintended consequence It appears by dropping shadowing we are no longer using slf4j logger at runtime, but default gradle logging implementation. This means unless --info is supplied to the gradle command, the logging information will not be displayed.

It relates to the following issue #s:

  • Fixes #147

cc @bhamail / @DarthHater / @guillermo-varela / @shaikhu

shaikhu avatar Jan 18 '24 10:01 shaikhu

Since we rely heavily on log output, perhaps we want to go ahead with this change alongside with https://github.com/sonatype-nexus-community/scan-gradle-plugin/issues/146 so all big changes start with a new major release together?

guillermo-varela avatar Jan 19 '24 02:01 guillermo-varela

Since we rely heavily on log output, perhaps we want to go ahead with this change alongside with #146 so all big changes start with a new major release together?

That sounds sensible to me 👍

shaikhu avatar Jan 19 '24 09:01 shaikhu