helm-nexus-push icon indicating copy to clipboard operation
helm-nexus-push copied to clipboard

remove set -u and reserved variable USERNAME

Open maozza opened this issue 6 years ago • 2 comments

fix unbound variable error, the script call USERNAME and PASSWORD before setting it. USERNAME is reserved in Ubuntu 18.04

This pull request makes the following changes:

  • remove set -u due to error .helm/plugins/helm-nexus-push.git/push.sh: line 104: PASSWORD: unbound variable
  • change reserved variable USERNAME (on ubuntu linux USERNAME is my os username)

(If there are changes to user behavior in general, please make sure to update the docs, as well)

It relates to the following issue #s:

  • Fixes #X

maozza avatar Jan 15 '19 14:01 maozza

Thanks for the contribution! Unfortunately we can't verify if the committer(s), maoz [email protected], signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

sonatypecla[bot] avatar Jan 15 '19 14:01 sonatypecla[bot]

@maozza See PR #1. We'll likely work on getting that one merged.

dtshepherd avatar Jan 15 '19 14:01 dtshepherd