sonata-doctrine-extensions
sonata-doctrine-extensions copied to clipboard
Adding TransactionalManagerInterface
Subject
I am targeting this branch, because it has the support for the php 7.4 version.
Related with #{put_issue_number_here}.
Changelog
### Added
- Added `TransactionalManagerInterface::class` interface.
You need to implement it in https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/src/Entity/BaseEntityManager.php
BaseEntityManager
or BaseManager
I don't really get what is the difference between both?
You need to implement it in https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/src/Entity/BaseEntityManager.php
BaseEntityManager
orBaseManager
I don't really get what is the difference between both?
BaseManager is a base for both doctrineORM and doctirneMOngo. BaseEntityManager is a bath for doctrineORMManagers
There is transaction in EntityManager so we can add it to BaseEntityManager. I'm not sure the same exists to MongoManager, and even if it exists, the impelmentation won't be the same
Linter is failing
Linter is failing
the phpcs I could run locally, But psalm doesn't work :/, Then I do not know it it was fixed!
I added the return type for tests
sorry for keeping you running the pipelines :(
let me know if it's missing something!
And what was the decision 👀
I think I found at least another case on SonataMediaBundle where this could be useful.
I think I found at least another case on SonataMediaBundle where this could be useful.
Can you explain what you have in mind ?
Nothing, I have searched where do we use transactions and are only on PageBundle