sonata-doctrine-extensions icon indicating copy to clipboard operation
sonata-doctrine-extensions copied to clipboard

Implements TransactionalManagerInterface

Open eerison opened this issue 3 years ago • 5 comments

Implements TransactionalManagerInterface and Use in SnapshotManagerInterface

This idea was raised in this PR: sonata-project/SonataPageBundle#1548

  • Create test for Create and cleanup snapshots, to make sure that beginTransaction and commit methods are called

eerison avatar Aug 11 '22 08:08 eerison

Ok we have the first problem here, sonata-doctrine-extension requires php 8

https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/composer.json

But in my option we should release 4.0 with support for 7.4 what do you think?

eerison avatar Aug 11 '22 08:08 eerison

@VincentLanglet

eerison avatar Aug 11 '22 08:08 eerison

Ok we have the first problem here, sonata-doctrine-extension requires php 8

https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/composer.json

But in my option we should release 4.0 with support for 7.4 what do you think?

It's not a problem. We can still introduce the feature for now. And we'll use it on PageBundle when the support for php 7.4/doctrine-extensions 2 will be dropped.

VincentLanglet avatar Aug 11 '22 09:08 VincentLanglet

Ok we have the first problem here, sonata-doctrine-extension requires php 8 https://github.com/sonata-project/sonata-doctrine-extensions/blob/2.x/composer.json But in my option we should release 4.0 with support for 7.4 what do you think?

It's not a problem. We can still introduce the feature for now. And we'll use it on PageBundle when the support for php 7.4/doctrine-extensions 2 will be dropped.

Ok I got it ;)

eerison avatar Aug 11 '22 09:08 eerison

IMO this issue should be moved to doctrine extensions

jordisala1991 avatar Aug 11 '22 10:08 jordisala1991

I would say it's done

eerison avatar Aug 16 '22 18:08 eerison