SonataPageBundle icon indicating copy to clipboard operation
SonataPageBundle copied to clipboard

Use twig blocks for form rendering

Open core23 opened this issue 9 years ago • 4 comments

We should replace all <form> elements in the twig templates with the twig function form_start and form_end. We should also move the action and method (POST, GET) attribute to the PHP files.

This would decouples the business logic from the layout.

Todo

The following files contains form elements.

  • [x] https://github.com/sonata-project/SonataPageBundle/blob/3.x/Resources/views/base_layout.html.twig
  • [ ] https://github.com/sonata-project/SonataPageBundle/blob/3.x/Resources/views/BlockAdmin/edit.html.twig
  • [ ] https://github.com/sonata-project/SonataPageBundle/blob/3.x/Resources/views/SiteAdmin/create_snapshots.html.twig
  • [x] https://github.com/sonata-project/SonataPageBundle/blob/3.x/Resources/views/SnapshotAdmin/create.html.twig

core23 avatar Aug 08 '16 15:08 core23

Depends on https://github.com/sonata-project/SonataAdminBundle/issues/4050, because we need to add something to the Datagrid.

core23 avatar Aug 14 '16 10:08 core23

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 30 '20 20:01 stale[bot]

Hey @core23 I saw that Resources/views/base_layout.html.twig was already checked as solved, But do you know which PR was it done 👀

eerison avatar Oct 13 '22 14:10 eerison