SonataPageBundle icon indicating copy to clipboard operation
SonataPageBundle copied to clipboard

Switch cocur/slugify to symfony/string

Open eerison opened this issue 9 months ago • 3 comments

Switch cocur/slugify to symfony/string

in order to use more symfony packages and keep this repo using the same dependencies as admin bundle

I suggest we change slugify to symfony/string!

in case it makes sense, then I will try to do it :D

eerison avatar Sep 08 '23 09:09 eerison

in case it makes sense, then I will try to do it :D

Sure it make sense ; but I dunno if we'll be able to drop the dependency in a BC way.

Pr is opened.

VincentLanglet avatar Sep 08 '23 09:09 VincentLanglet

Yeah, we need to keep the dependency in 4.x and remove in 5.x only.

We need the both dependencies to keep BC compatibility

eerison avatar Sep 08 '23 09:09 eerison

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 06 '24 11:03 github-actions[bot]