SonataAdminBundle icon indicating copy to clipboard operation
SonataAdminBundle copied to clipboard

Questionning about sonata.admin.action.retrieve_form_field_element

Open ec-ecss opened this issue 3 years ago • 1 comments

Admin Bundle 4.13.0

I'm not sure if it's a bug so I put it on feature request on vendor/sonata-project/admin-bundle/src/Action/RetrieveFormFieldElementAction.php A handleRequest is made Is the handleRequest necessary ? It seems that the ajax request that need handleRequest to modify the entity is already executed in the precedent call, and it's just a refresh call to update client html. The context : I was implementing a n-n file upload, and the only solution to made work it properly is to override the service sonata.admin.action.retrieve_form_field_element , with the same code but without the handleRequest. Without that, I've got a empty field. I can make a PR if you think the handleRequest is not needed

Thanks !

ec-ecss avatar Aug 30 '22 12:08 ec-ecss

Best would be to provide a failing test, to prove that the handleRequest need to be removed.

But I never got any issue with this action.

VincentLanglet avatar Aug 31 '22 07:08 VincentLanglet

As it's a question and not an issue, and there isn't any interaction from @CaptainKant , IMO we can close this issue :)

eerison avatar Dec 02 '22 11:12 eerison