Sona Chitchyan

Non-LTE Rate Equation Solver

1

### :pencil: Description **Type:** :beetle: `bugfix` | :rocket: `feature` | :biohazard: `breaking change` | :vertical_traffic_light: `testing` | :memo: `documentation` | :roller_coaster: `infrastructure` Write a complete description of your changes, including...

Adding needed functionality to nonhom_grip.py

2

### :pencil: Description Adding nonhom_grid.py that includes velocity and $ \frac{dv}{dr}$ functions for shells and finding tau_sobolev_factor Some of the changes shown here are part of https://github.com/tardis-sn/tardis/pull/2024 Also, link issues...

Adding nonhomologous grid

1

### :pencil: Description **Type:** :roller_coaster: `infrastructure` Swtiched `get_doppler_factor` and `get_inverse_doppler_factor` to use v(velocity) instead of r(radial distance) Added nonhomologous_grip.py for future use of nonhomologous expansion. This part is not connected...

Adding rate matrix index

3

### :pencil: Description **Type:** `infrastructure` This PR addds the NLTEIndexHelper class which has the output `rate_matrix_index`. This will be used for constructing the rate equation for solving NLTE ionization and...

adding nonhomologous_grid.py

1

### :pencil: Description **Type:** :beetle: `bugfix` | :rocket: `feature` | :biohazard: `breaking change` | :vertical_traffic_light: `testing` | :memo: `documentation` | :roller_coaster: `infrastructure` This PR adds nonhomologous_grid.py to montecarlo/montecarlo_numba for further...

NLTE excitation solver

1

### :pencil: Description **Type:** :beetle: `bugfix` | :rocket: `feature` | :biohazard: `breaking change` | :vertical_traffic_light: `testing` | :memo: `documentation` | :roller_coaster: `infrastructure` This PR implements NLTE excitation solver Also, link...

**Describe the bug** The tests in ```test_montecarlo.py``` get skipped. We should go through them and keep the ones we actually need. **To Reproduce** **Screenshots** **System** - OS: - [ ]...

**Describe the bug** NLTEData is defined and used both in [io/atom_data/base.py](https://github.com/tardis-sn/tardis/blob/fbb784b772db5cc52d8df1961f34431eebc3fbf9/tardis/io/atom_data/base.py#L550) and [plasma/properties/nlte_excitation_data.py](https://github.com/tardis-sn/tardis/pull/2201/files/b82b20077e9c8a8e714c2578b7044c7a078ef7e4#diff-6f33d8b5477ba4dfd44d4500278f1e7c323182b9333532ca609d8d5d866aa8a1R8) **To Reproduce** **Screenshots** **System** - OS: - [ ] GNU/Linux - [ ] macOS - Environment (`conda...

**Describe the bug** In [nlte_rate_equation_solver](https://github.com/tardis-sn/tardis/blob/97445dc52d387aeee59e7ff1030031fb21cd7566/tardis/plasma/properties/nlte_rate_equation_solver.py#L717) `prepare_bound_bound_rate_matrix` is designed for creating the bound-bound rate matrix for multiple shells at once, which is might not necessarily be the fastest way. **To Reproduce**...

Quickstart should set collisions to True

1

**Describe the bug** When running the quickstart with collisions=True in cmfgenreader, it breaks TARDIS. **To Reproduce** **Screenshots** **System** - OS: - [ ] GNU/Linux - [ ] macOS - Environment...