docker-observium icon indicating copy to clipboard operation
docker-observium copied to clipboard
verified publisher icon somsakc

Fix env variable & Run observium-init.sh before spawning supervisord

Open twirtgen opened this issue 7 months ago • 2 comments

Hello,

This PR resolves two issues:

  • Put OBSERVIUM_* environment variables in quotes to prevent special bash characters from being interpreted.
  • Make sure that observium-init.sh is run before starting supervisord. This avoids log errors during container startup and prevents race conditions if observium starts before observium-init.sh has finished.

I've made the changes for both amd64 and arm32, but I only tested on amd64. I guess this should work on arm32 as well.

Feel free to let me know if I need to adjust or change anything in this PR.

twirtgen avatar May 11 '25 20:05 twirtgen

Hey,

After some thought, it seems that the variables are not escaped correctly if they contains characters like " or \.

I'll leave the PR as a draft for now. I will continue to work on it when I have more time.

twirtgen avatar May 11 '25 22:05 twirtgen

I think the PR is ready for review.

Let me know if there is anything else I need to do.

twirtgen avatar May 17 '25 12:05 twirtgen