Compile Warning

Open bypepe opened this issue 1 year ago • 1 comments

esp_dmx\src\dmx\driver.c: In function 'dmx_driver_install': esp_dmx\src\dmx\driver.c:49:32: warning: passing argument 2 of 'rdm_register_manufacturer_label' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] #define RDM_MANUFACTURER_LABEL "esp_dmx" ^~~~~~~~~ esp_dmx\src\dmx\driver.c:214:44: note: in expansion of macro 'RDM_MANUFACTURER_LABEL' rdm_register_manufacturer_label(dmx_num, RDM_MANUFACTURER_LABEL, NULL, NULL); ^~~~~~~~~~~~~~~~~~~~~~ In file included from esp_dmx\src/rdm/responder.h:53, from esp_dmx\src/rdm/responder/include/utils.h:13, from esp_dmx\src/dmx/include/service.h:16, from \esp_dmx\src\dmx\driver.c:9: esp_dmx\src/rdm/responder/include/product_info.h:152:44: note: expected 'char *' but argument is of type 'const char *' char *manufacturer_label,

Mar 22 '24 12:03 bypepe

At a cursory glance, it seems like a possible solution would be to change rdm_register_manufacturer_label to accept a const char* instead of a char*. Am I missing something there? Would that break things?

Jun 22 '25 23:06 thirstyice