hardware-bitcoin-wallet
hardware-bitcoin-wallet copied to clipboard
someone42
A minimal Bitcoin wallet intended for embedded devices
I try to make it and do not work ``` make all -------- begin -------- avr-gcc (GCC) 4.8.2 Copyright (C) 2013 Free Software Foundation, Inc. This is free software; see...
using static const char * instead of static char* for PROGMEM.
ASKUSER_NUKE_WALLET is undefined. Can't find any file where it is defined.
As per section 8.4.5 of USB2.0, the endpoint data toggle sync bits of Interrupt endpoints should be reset after a "Set configuration" request.
Test case coverage of transaction fee calculation is not good enough.
There are lots of loops which hash over a byte buffer. hashWriteByte should be changed to hashWriteBytes. Also, public key serialisation happens a few times; this should be refactored into...
Where appropriate, const should be used to make it more difficult to overwrite an input parameter.
To avoid some race conditions, interrupts should be disabled before pre-WFI preparation. Some testing is required to ensure that this doesn't halt the core.
The use of "transaction hash" is misleading; it should be changed. "Input transactions" should be referred to as "supporting transactions".
If a command which calls setEncryptionKey() fails, the new encryption key should be replaced with the old one.