gcp-jwt-go
gcp-jwt-go copied to clipboard
someone1
Moving to maintained golang-jwt/jwt
This PR will move the jwt-go library to the maintained golang-jwt/jwt fork of the jwt-go library, as discussed in http://github.com/dgrijalva/jwt-go/issues/462.
@lazeratops @oxisto - My sincerest apologies! I'm not sure how I didn't see the notification for this PR. I will make it a point to get this reviewed/merged soon!
Since this will technically be a breaking change, I want to jump onto the latest version of the new repo which is now tagged as v4 (migration guide).
That being said, I'd also have to modify this repo's go module version and deps accordingly (e.g. tagging a v3).
I think we'll want to enhance this PR a little but it's a great start, thank you @oxisto!
Since this will technically be a breaking change, I want to jump onto the latest version of the new repo which is now tagged as v4 (migration guide).
That being said, I'd also have to modify this repo's go module version and deps accordingly (e.g. tagging a v3).
I think we'll want to enhance this PR a little but it's a great start, thank you @oxisto!
Yes, going for the v4 definitely makes sense.
I think we just need to bump the go.mod version to v3 so when I merge this and tag it as v3 things work as expected. Also wanted to try this out on some of my projects before merging but I've moved roles since writing this package.
@oxisto / @ksimir - can you confirm if this branch works as intended if you have any production projections you can test this out on?
Sorry for the late reply, not something in prod but as far as I tested, I didn't see any issue.
@someone1 Did you have a chance to try it on your side? I think it's safe to bump to v3 and merge.
@someone1 Sorry to pile on here, but this would be great if you could get this merged 😄
