npu icon indicating copy to clipboard operation
npu copied to clipboard

Published 20 hours ago • verified publisher icon solymosi

ELTE Homepage update

Open leggenda47 opened this issue 4 years ago • 5 comments

Supposed to resolve #51

leggenda47 avatar Dec 05 '20 22:12 leggenda47

It works perfectly, thanks! @solymosi could you review and merge it?

gy-mate avatar Jan 23 '21 16:01 gy-mate

Thanks a lot for the PR! 🎉

My only issue is that we are adding lots of ELTE-specific stuff to some quite central places in the codebase, which is going to reduce maintainability. Let me see if I can do some refactoring first.

solymosi avatar Jan 25 '21 15:01 solymosi

I will integrate this once this refactor is done & merged: https://github.com/solymosi/npu/pull/56

solymosi avatar Jan 25 '21 20:01 solymosi

My only issue is that we are adding lots of ELTE-specific stuff to some quite central places in the codebase

Isn't ELTE the biggest and the best university, though?

(And if the political situation continues as-is, will be the only one remaining...)

whisperity avatar Feb 03 '21 19:02 whisperity

With the 2.0 refactoring done we can now put all this into its own module and selectively enable it just on the ELTE domains. I'll land this soon.

solymosi avatar Feb 03 '21 19:02 solymosi

Sorry, I simply don't have time to work on this. If anyone else wants to pick it up, feel free to submit another PR. For now I'll close it.

solymosi avatar Dec 09 '22 10:12 solymosi