phat

phat copied to clipboard

Hi, just wanted to commend the library - I implemented a very similar library in Haskell some time ago and got an idea today to look for similar libraries in...

Martinsos

rleonid

When trying to build phat with opam 2.0, it complains about the ocaml-version field. ``` error 32: Field 'ocaml-version:' and variable 'ocaml-version' are deprecated, use a dependency towards the 'ocaml'...

rdavison

b823ec53abf34b8a130922ed07bd8d3aab4fe961 deleted an instance of `open Core` in `cli.ml`. This might be wrong since we still `open Async` in that file. We should resolve the matter by doing these kind...

agarwal

check for cycles

6

Symbolic links lead to the possibility of cycles. Cycles are not necessarily wrong, so we don't consider them ill-formed at construction time. However, some operations will lead to an infinite...

agarwal

- [XDG Base Directory Specification](http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html) - [Debian's recommendation to use XDG spec](https://wiki.debian.org/XDGBaseDirectorySpecification) - OCaml library [ocaml-xdg-basedir](http://xdg-basedir.forge.ocamlcore.org/api/) that already implements it.

agarwal

`Cli.{abs_file, abs_dir}` should support autocompletion.

agarwal

All code related to tests is in one monolothic file. Improvements would be: - Create a `test` library. Move virtually all code there and follow corresponding design guide, e.g. provide...

agarwal

make sure test execution is reproducible

1

It seems to me that ounit runs tests in parallel, which makes our use of `Random` functions not reproducible. This is not great for (cross-platform) debugging, and should be fixed....

pveber

normalization should not affect the resolved path

1

``` ocaml # let x = Cons (Link(name_exn "foo", Item Dot), Item Dotdot);; val x : (rel, dir) t = Cons (Link ("foo", Item Dot), Item Dotdot) # normalize x;;...

agarwal