solo-webupdate icon indicating copy to clipboard operation
solo-webupdate copied to clipboard

Do not use _blank

Open szszszsz opened this issue 5 years ago • 1 comments

Recently _blank was added to index.html, as a new target for opened links. It might be maliciously used. Please use the suggested alternative, or complementary attribute. References:

  • https://www.quora.com/Is-it-wrong-and-why-to-use-target-_-blank-for-a-html-link
  • https://medium.com/@ali.dev/how-to-fix-target-blank-a-security-and-performance-issue-in-web-pages-2118eba1ce2f
  • https://blog.dareboost.com/en/2017/03/target-blank-links-rel-noopener-performance-security/

Commit: https://github.com/solokeys/solo-webupdate/commit/defb625f160e0fa3083da321888576678faa0230 Source: https://github.com/solokeys/solo-webupdate/blob/a19891e4a0036128c2a756007242d1a155e336ef/index.html#L42

cc: @StoyanDimitrov

szszszsz avatar Sep 04 '19 16:09 szszszsz

ouch I never knew this is a thing. good info

My1 avatar Sep 04 '19 16:09 My1