gloo icon indicating copy to clipboard operation
gloo copied to clipboard

k8s gateway route delegation should warn on matcher conflict

Open jenshu opened this issue 6 months ago • 0 comments

Gloo Edge Product

Open Source

Gloo Edge Version

v1.17.x

Is your feature request related to a problem? Please describe.

[Note this issue pertains to our Kubernetes Gateway API integration, but should also be handled separately for Edge APIs]

When we enable parent matcher inheritance, parent and child route matches are merged, and in some cases child matcher fields are overwritten/dropped silently:

  • header matches: for any conflicting header names, only the parent header match is used
  • query params: for any conflicting query param names, only the parent query param match is used
  • method: if parent specifies a method matcher, that will be used in favor of any child method matcher

We should at the least log a warning in the case of dropped child matchers. Perhaps consider adding it to the resource statuses as well.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional Context

No response

┆Issue is synchronized with this Asana task by Unito

jenshu avatar Aug 01 '24 13:08 jenshu