gloo icon indicating copy to clipboard operation
gloo copied to clipboard

DO NOT MERGE Expose disable dynamic stats (#9260)

Open ashishb-solo opened this issue 10 months ago • 0 comments

  • Very rough implementation before protogen

  • Run make generate-all. https://xkcd.com/499/

  • Regenerate code with correct version of protoc

  • Cleaner implementation of setting dynamic_stats

  • Add a test to set both options on the router

dynamic_stats and suppress_envoy_headers can both be set in this test

  • Clean up the unit tests in a big way

  • A little more clean-up

  • Update changelog

  • Update changelog wording

  • Move router tests to separate file

  • Remove more redundant code in the table tests

  • Remove focus

  • Add TODO to address creating a new router plugin

  • Re-run codegen

  • Use HttpListener translator and fix table name


Description

Please include a high level summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Fill out any of the following sections that are relevant and remove the others

API changes

  • Added x field to y resource
  • ...

Code changes

  • Fix error in Foo() function
  • Add Bar() function
  • ...

CI changes

  • Adjusted schedule for x job
  • ...

Docs changes

  • Added guide about feature x to public docs
  • Updated README to account for y behavior
  • ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

See slack conversation here

Interesting decisions

We chose to do things this way because ...

Testing steps

I manually verified behavior by ...

Notes for reviewers

Be sure to verify intended behavior by ...

Please proofread comments on ...

This is a complex PR and may require a huddle to discuss ...

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

ashishb-solo avatar Mar 27 '24 16:03 ashishb-solo