gloo icon indicating copy to clipboard operation
gloo copied to clipboard

Add name option for glooctl command

Open kevin-shelaga opened this issue 1 year ago • 8 comments

Gloo Edge Product

Enterprise

Gloo Edge Version

1.15.x

Is your feature request related to a problem? Please describe.

Customer runs Gloo with a different name, would like the add a glooctl name flag for commands.

Describe the solution you'd like

Glooctl get proxy -name my-gloo

Describe alternatives you've considered

Kubectl commands where possible

Additional Context

No response

Related Issues

  • [ ] https://github.com/solo-io/gloo/issues/8700

kevin-shelaga avatar Feb 16 '24 20:02 kevin-shelaga

by name do you mean the gloo-pod's name? namespace? or label?

nfuden avatar Feb 16 '24 21:02 nfuden

@nfuden Gloo pod name, though potentially this could include pointing Glooctl to different proxy names as well

kevin-shelaga avatar Feb 18 '24 23:02 kevin-shelaga

Zendesk ticket #3255 has been linked to this issue.

soloio-bot avatar Feb 19 '24 18:02 soloio-bot

Clarification: iS there a standard rename or a per pod situation?

It sounds like its just a way to rename each of our default pod names.

If we decide to add this functionality we MUST add this to our glooctl configuration file.

nfuden avatar Mar 04 '24 00:03 nfuden

@kevin-shelaga Can we ask the customer for an example of what they need? I check the Zendesk ticket, and that mentions the glooctl get proxy command .... but glooctl get proxy already accepts a --name parameter ... so I'm a bit confused ...

I.e., just tried this out in a sample environment with 3 GW deployments:

glooctl get proxy --name public-gw

... and that works fine.

DuncanDoyle avatar Apr 16 '24 16:04 DuncanDoyle

After upgrading the "glooctl" tool and adding labels (app: gloo, gloo: gloo) to "gloo" everything looks fine. The ZD ticket has been closed and we should be able to close this GH issue as well.

jswinner09 avatar Jun 06 '24 18:06 jswinner09

Hello @DuncanDoyle, it doesn't work in my case:

kubectl get deploy -n gloo-system|grep gloo
gloo-deploy                              1/1     1            1           23m
gloo-fed                                 1/1     1            1           174m
gloo-fed-console                         1/1     1            1           174m
glooe-grafana                            1/1     1            1           174m
glooe-prometheus-kube-state-metrics-v2   1/1     1            1           174m
glooe-prometheus-server                  1/1     1            1           174m

kubectl get pod -l gloo=gloo -n gloo-system                                                                                        
NAME                           READY   STATUS    RESTARTS   AGE
gloo-deploy-58756d5458-pftcl   1/1     Running   0          7m32s
glooctl check -p gloo=gloo
Checking deployments... OK
Checking pods... OK
Checking upstreams... OK
Checking upstream groups... OK
Checking auth configs... OK
Checking rate limit configs... OK
Checking VirtualHostOptions... OK
Checking RouteOptions... OK
Checking secrets... OK
Checking virtual services... OK
Checking gateways... OK
Checking proxies... Error from server (NotFound): deployments.apps "gloo" not found
Error from server (NotFound): deployments.apps "gloo" not found
^C

glooctl get proxy --name gloo-deploy                                                                                               
Error from server (NotFound): deployments.apps "gloo" not found

glooctl version
Client: {"version":"1.16.10"}
Server: {"type":"Gateway","enterprise":true,"kubernetes":{"containers":[{"Tag":"latest","Name":"discovery-ee","Registry":"quay.io/solo-io"},{"Tag":"latest","Name":"extauth-ee","Registry":"quay.io/solo-io"},{"Tag":"latest","Name":"gloo-ee-envoy-wrapper","Registry":"quay.io/solo-io"},{"Tag":"latest","Name":"gloo-ee","Registry":"quay.io/solo-io","OssTag":"1.16.12"},{"Tag":"latest","Name":"observability-ee","Registry":"quay.io/solo-io"},{"Tag":"latest","Name":"rate-limit-ee","Registry":"quay.io/solo-io"},{"Tag":"7.0.11","Name":"redis","Registry":"docker.io"}],"namespace":"gloo-system"}}

htech7x avatar Jun 21 '24 20:06 htech7x

Zendesk ticket #3977 has been linked to this issue.

soloio-bot avatar Jun 25 '24 17:06 soloio-bot

This will be in OSS v1.13.39, v1.14.32, v1.15.30, v1.16.18, v1.17.0 and Enterprise v1.13.35, v1.14.20, v1.15.20, v1.16.12, v1.17.0

davidjumani avatar Jul 10 '24 14:07 davidjumani