gloo
gloo copied to clipboard
Aerospike connection settings
Description
API change needed for solo-io/solo-projects#5644
Note: additional fields are likely to be added as described in Slack here
API changes
- Added fields to
AerospikeApiKeyStorage
message, corresponding with Aerospike client settings with descriptions from Aerospike docs
Context
Consumed by solo-io/ext-auth-service#706 and solo-io/solo-projects#5661
Interesting decisions
Alternatives would be to add these settings to a new sub-message or a generic map field, however they are ruled out for the following reasons:
- A sub-message for client settings might make logical sense, however TLS settings which also configure the client are already present in
AerospikeApiKeyStorage
and so we opt to follow the existing pattern - A generic map would theoretically allow us to account for any settings in code without a future API change, however it would then be unclear exactly what we support, at least until an error occurs at runtime
Testing steps
This PR only contains API changes, see extauth and solo-projects PRs for functionality changes
Notes for reviewers
Consider this PR alongside the extauth and solo-projects PRs
Checklist:
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works