gloo icon indicating copy to clipboard operation
gloo copied to clipboard

Published 20 hours ago • verified publisher icon solo-io

Use go.mod as the source of truth for go version

Open ben-taussig-solo opened this issue 1 year ago • 1 comments

Gloo Edge Product

Open Source

Gloo Edge Version

v1.16.0-beta6

Is your feature request related to a problem? Please describe.

  • Currently, the GOLANG_ALPINE_IMAGE_NAME variable in the Makefile derives the go version associated with the current branch of Gloo OSS from the user's local go installation
  • https://github.com/solo-io/gloo/blob/c6ae0a7f6e943cff7f4a226dd68a094794cf42e0/Makefile#L75

Describe the solution you'd like

  • Instead, we should derive this value from go.mod, which should be considered the single source of truth
  • https://github.com/solo-io/gloo/blob/c6ae0a7f6e943cff7f4a226dd68a094794cf42e0/go.mod#L3

Describe alternatives you've considered

No response

Additional Context

Given the introduction of Go Toolchains in 1.21, it is particularly important to ensure that the GOLANG_ALPINE_IMAGE_NAME variable is derived from go.mod rather than the user's local go installation.

ben-taussig-solo avatar Dec 12 '23 20:12 ben-taussig-solo