gloo icon indicating copy to clipboard operation
gloo copied to clipboard

support rate-limit with built in Redis when using multiple dataplanes

Open totallyGreg opened this issue 1 year ago • 2 comments

Gloo Edge Product

Enterprise

Gloo Edge Version

v1.14.8

Kubernetes Version

unknown

Describe the bug

When using the feature dataPlanePerProxy, rate-limit pods cannot talk to the respected redis instances since the redis config map generated is set for a single control and data plane solution and it is referencing the wrong redis service

Expected Behavior

rate-limit should be configured to use an existing redis instance for their respective data plane.

Steps to reproduce the bug

Gloo EE version: 1.14.8

Our Structure: • 1 gloo instance (control plane) • 2 gateway-proxies, extauth, ratelimit, and redis instances (data plane) The name of the redis and rate-limit instances: • rate-limit-internal-proxy should talk to redis-internal-proxy • and rate-limit-gateway-proxy should talk to redis-gateway-proxy It looks like the issue is the rate-limit-sidecar-config which is being used by both rate-limit instances, which referenced this service:

          endpoints:
          - lbendpoints:
            - endpoint:
                address:
                  socketaddress:
                    address: redis   <---- this does not exists
                    port_value: 6379

Additional Environment Detail

No response

Additional Context

No response

totallyGreg avatar Dec 11 '23 20:12 totallyGreg

Zendesk ticket #2887 has been linked to this issue.

soloio-bot avatar Dec 11 '23 20:12 soloio-bot

Related to https://github.com/solo-io/gloo/issues/9101

nfuden avatar Feb 07 '24 20:02 nfuden

@bewebi i think this is now supported via having multi built in redis instances. Can you please confirm?

nfuden avatar Apr 26 '24 13:04 nfuden

Can confirm, this is supported as of v1.16.3 and v1.17.0-beta1

bewebi avatar Apr 26 '24 14:04 bewebi