gloo icon indicating copy to clipboard operation
gloo copied to clipboard

Waf dynamic load

Open ianmacclancy opened this issue 2 years ago • 2 comments

Description

Please include a summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

Checklist:

  • [ ] I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • [ ] If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • [ ] I followed guidelines laid out in the Gloo Edge contribution guide
  • [ ] I opened a draft PR or added the work in progress label if my PR is not ready for review
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

ianmacclancy avatar Sep 22 '22 18:09 ianmacclancy

Issues linked to changelog: https://github.com/solo-io/gloo/issues/3329

solo-changelog-bot[bot] avatar Sep 22 '22 18:09 solo-changelog-bot[bot]

Visit the preview URL for this PR (updated for commit 650089f):

https://gloo-edge--pr7216-wafdynamicload-5h7qd2cb.web.app

(expires Tue, 18 Oct 2022 22:34:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Sep 22 '22 19:09 github-actions[bot]

can you add to the description of the PR what steps need to be taken with the added API changes that would enable this feature? It was not quite clear to me what needs to be done from a configuration standpoint.

Do I set custom_config_map_rule_sets and then have to set the core_rule_set. custom_settings_file?

jackstine avatar Sep 30 '22 18:09 jackstine

can you add to the description of the PR what steps need to be taken with the added API changes that would enable this feature? It was not quite clear to me what needs to be done from a configuration standpoint.

Do I set custom_config_map_rule_sets and then have to set the core_rule_set. custom_settings_file?

Yup! I can add something more descriptive. This is not changing behavior but adding a new field to allow for dynamic loading from configmaps. It is an EE only behavior so customers don't "need" to do anything to enable this. They will need to create configmaps containing the data they want to use as WAF rulesets. This data would be the same data you could use in a file under ruleSets.

ianmacclancy avatar Oct 03 '22 17:10 ianmacclancy

/kick

ianmacclancy avatar Oct 11 '22 19:10 ianmacclancy

Visit the preview URL for this PR (updated for commit cefedb3):

https://gloo-edge--pr7216-wafdynamicload-5h7qd2cb.web.app

(expires Tue, 25 Oct 2022 14:44:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

github-actions[bot] avatar Oct 14 '22 20:10 github-actions[bot]

/kick

ianmacclancy avatar Oct 17 '22 20:10 ianmacclancy