gloo icon indicating copy to clipboard operation
gloo copied to clipboard

create debug images with the required options for profiling Envoy

Open bcollard opened this issue 3 years ago • 1 comments

Version

1.10.x (beta)

Is your feature request related to a problem? Please describe.

Some users would like to profile Envoy, as explained on this page: https://github.com/envoyproxy/envoy/blob/main/bazel/PPROF.md

Describe the solution you'd like

enable "debug symbols and gperftools in the Envoy binary"

Describe alternatives you've considered

No response

Additional Context

No response

bcollard avatar Jan 12 '22 13:01 bcollard

This is more of a product issue because the debug image exposes Enterprise code.

chrisgaun avatar Mar 08 '22 14:03 chrisgaun

Source code isn't obtainable from debug symbols, but a skilled programmer could rewrite an application's logic given the debug symbols and a lot of time. https://stackoverflow.com/questions/5532415/obtain-source-using-debugging-symbols#:~:text=The%20easy%20answer%20is%20No%2C%20you%20can't.

saiskee avatar Aug 22 '22 14:08 saiskee

Oh. Got it. This should not be problem

chrisgaun avatar Aug 22 '22 20:08 chrisgaun

We are currently running into issues trying to create and release the debug image in Cloudbuild due too the increased space requirements of the debug issue (~2.4GB vs ~200MB) Potential paths forward are:

  • Attempt to modify the CI script to use fewer resources
  • Allocate the required resources to the Cloudbuild

I'm not sure what the total requirements of the job are/will be, what the resource limit currently is, or how to modify it

bewebi avatar Aug 23 '22 14:08 bewebi

solo-io/envoy-gloo-ee#405 is open under review It adds steps in CI to build and release debug images that can be profiled for tagged releases

bewebi avatar Aug 31 '22 17:08 bewebi

This has now been merged Debug images will be build and published for future tagged releases

bewebi avatar Aug 31 '22 19:08 bewebi

Reopening to also provide envoy-wrapper images by default.

nfuden avatar Sep 12 '22 13:09 nfuden

We will only be backporting to 1.11 and only publishing on new releases

nfuden avatar Sep 16 '22 13:09 nfuden

debug images are now available in v1.12.18+

gunnar-solo avatar Sep 16 '22 13:09 gunnar-solo

This should be available 1.11.41

nfuden avatar Sep 22 '22 14:09 nfuden