gloo icon indicating copy to clipboard operation
gloo copied to clipboard

glooctl -o kube-yaml format is not respected for some types

Open jenshu opened this issue 3 years ago • 2 comments

Describe the bug glooctl create secret ... --dry-run -o kube-yaml is missing the kind and apiVersion in the output. It currently does the same thing as -o yaml.

Expected behavior The command should output valid k8s yaml that can be applied.

Need to fix this for secret, authconfig, and ratelimitconfig.

jenshu avatar Jun 11 '21 19:06 jenshu

This was brought up again with regards to unexpected output formats. As part of this issue we should also attempt to enforce failing noisily on glooctl commands when asked for an output type that is not supported by the given command.

For example we could make a package that contains the unsupported output type errors and then output it anywhere needed. A bigger lift could combine with a checker to make sure that either all output types are mentioned in a file or a test that runs the same command with different output types and checks that the output is different (ie truly a different format)

nfuden avatar May 12 '22 16:05 nfuden

This issue has been marked as stale because of no activity in the last 180 days. It will be closed in the next 180 days unless it is tagged "no stalebot" or other activity occurs.

github-actions[bot] avatar Jan 20 '24 10:01 github-actions[bot]

This issue has been closed due to no activity in the last 12 months.

github-actions[bot] avatar Jul 19 '24 10:07 github-actions[bot]