gloo
gloo copied to clipboard
solo-io
Feat: Expose envoy's`config.filter.accesslog.v2.AccessLogFilter`
Use-case
I want to enable Access Logs for tracking but the number of logs is overwhelming. I'd like to use config.filter.accesslog.v2.RuntimeFilter to log just a percentage of the logs
https://www.envoyproxy.io/docs/envoy/latest/api-v2/config/filter/accesslog/v2/accesslog.proto#envoy-api-msg-config-filter-accesslog-v2-runtimefilter
Feature request
Expose envoy's config.filter.accesslog.v2.RuntimeFilter in Gloo's Gateway CRD
Something like this:
apiVersion: gateway.solo.io/v1
kind: Gateway
metadata:
annotations:
origin: default
name: gateway
namespace: gloo-system
spec:
bindAddress: '::'
bindPort: 8080
proxyNames:
- gateway-proxy
httpGateway: {}
useProxyProto: false
options:
accessLoggingService:
accessLog:
- fileSink:
path: /dev/stdout
+ filter:
+ runtime_filter:
+ runtime_key: somekey
+ percent_sampled:
+ numerator: "..."
+ denominator: "..."
+ use_independent_randomness": true
stringFormat: ""
I am also interested in the ability to use envoy's access log filter. I was using it before we moved to gloo from a custom control plane to log requests that resulted in 4xx or 5xx responses.
@yuval-k Is there any chance to get this feature implemented? Within high load systems it's nearly impossible to log each and every access due to massive performance degradation of Gloo as well as massive performance impact on log forwarders and log indexers, but sampled logs could be really helpful. I also don't know if there is a chance to enable/disable access logs dynamically as it's possible with envoy's router logs etc.
