Peter Solnica

Results 573 comments of Peter Solnica

Closing as this will not be addressed. Just use pattern matching provided by Ruby.

> API would be something like this: > > ```ruby > logger.struct my_message: "Something happened" > ``` What's the reasoning for having a special method for structured logging? Typically, logging...

Another option is to decorate tasks with Sentry based on configuration. For example we could have `config.monitored_rake_tasks = ["db:migrate", "my_app:*"]` and then go through this and do `Rake::Task[name_of_task].extend(Sentry::Rake::Task)`. This way...

@sl0thentr0py do we want to support both and make it configurable?

Oh interesting. This does look like a bug because using `params` should preset processor to use params coercion regardless of the parent schema. Thanks for reporting this, good catch.

Did you update some dry-rb gems at the same time?

I'm sorry it took so long, I'll push a release, thanks for addressing it

Thanks for reporting this. Looks like filters are not added when an external schema is passed to `hash` macro.

I suppose we could add a custom form builder to dm-rails that builds form objects which wrap domain objects.