Peter Solnica

Results 573 comments of Peter Solnica

_From @mrship on January 31, 2017 11:50_ It turns out that using commit is _not_ a practical workaround as it doesn't actually work. Per the code below if you call...

@mrship seems like a weird and nasty bug, looking into it

@mrship OK I fixed it in 1.0.1 (released already)

_From @mrship on January 31, 2017 12:29_ Thanks for the quick response.

_From @flash-gordon on February 12, 2017 22:22_ I have some news about this. Sequel currently does not support `RETURNING` for Oracle. Instead it queries the sequence associated with the table...

@flash-gordon you do what you gotta do :) I don't use Oracle so I don't have much to say. Feel free to push a release once this is sorted out

_From @mrship on February 13, 2017 17:37_ @flash-gordon Thanks for looking at this. I had a similar issue when trying to use changesets on a table that has no primary...

_From @flash-gordon on February 14, 2017 13:58_ @mrship I recently added a check for PK presence https://github.com/rom-rb/rom-sql/blob/40885890ef33f4c1cd23e71019a4a616985f7f0b/lib/rom/sql/relation.rb#L94-L97

_From @flash-gordon on February 26, 2017 18:36_ heh, it took me a while https://github.com/jeremyevans/sequel/pull/1312/files

For the record, this is what we should support: ```ruby root.where { lower(field).in(["value1", "value2"]) } ``` Return types should not be required in `where` blocks after all.