react-native-ci icon indicating copy to clipboard operation
react-native-ci copied to clipboard

Published 20 hours ago • verified publisher icon solinor

Default to .aab builds with Play Store

Open arno-le opened this issue 5 years ago • 5 comments

Changed template Fastfile to use Android App Bundle as default. Reasons to use .aab include smaller app size and no need to build for separate CPU architectures, as that is handled by the Play Store. More info here: https://developer.android.com/platform/technology/app-bundle

As of now, Crashlytics does not support .aab -format.

arno-le avatar Oct 17 '19 08:10 arno-le

Hey thanks for the PR. This is definitely something we want to support, but probably would be good to make it a user decision, which option to choose from. It would require adding a prompt and changing the template depending on the choice. Would you be willing to add that?

plrdev avatar Dec 06 '19 20:12 plrdev

Sure!

arno-le avatar Dec 18 '19 12:12 arno-le

@eduplus Added a prompt to select the build variant. Additionally, I feel like the askQuestion method in android.js should be refactored or removed

arno-le avatar Jan 13 '20 09:01 arno-le

Thanks, this looks good to me, @miguelrrc promised to check that it works with his (long in waiting) PR, which does a lot on Android side as well. Hopefully we can merge these both in soon.

plrdev avatar Jan 23 '20 08:01 plrdev

It is good to go! 👍

miguelrrc avatar Feb 13 '20 06:02 miguelrrc