solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Handle failing foreign key additions

Open mamhoff opened this issue 9 months ago • 1 comments

Summary

We've added some foreign key constraints recently, and have since come up with a nicer way of guiding users towards fixing their data intentionally.

This change gives them a nice error message and allows them to change the migration to remove offending records.

Co-Authored-By: [email protected]

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

mamhoff avatar Jun 19 '25 13:06 mamhoff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.97%. Comparing base (55a1be5) to head (55dd557). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6293   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         861      861           
  Lines       18416    18416           
=======================================
  Hits        16386    16386           
  Misses       2030     2030           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 19 '25 14:06 codecov[bot]