solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Move LoadPromotions out of OrderAdjuster namespace

Open mamhoff opened this issue 9 months ago • 1 comments

Summary

Loading the currently available promotions can be quite useful outside of the order adjuster. This moves the LoadPromotions class out of there and into the main SolidusPromotions namespace so that it's clear that this class can be used elsewhere.

Extracted from #6287

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

mamhoff avatar Jun 18 '25 12:06 mamhoff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.98%. Comparing base (bbca5cc) to head (987fd44). Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6292      +/-   ##
==========================================
+ Coverage   86.65%   88.98%   +2.32%     
==========================================
  Files         521      863     +342     
  Lines       11943    18425    +6482     
==========================================
+ Hits        10349    16395    +6046     
- Misses       1594     2030     +436     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 18 '25 12:06 codecov[bot]