Standardrb

[tvdeyen]

Summary

• [ ] Manually fix remaining offences
• [ ] Add standard-rails?

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• [ ] I agree that my PR will be published under the same license as Solidus.
• [ ] I have written a thorough PR description.
• [ ] I have kept my commits small and atomic.
• [ ] I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[chaimann]

huge! not sure if you've finished fixing all the offences, but if not, we could potentially benefit from generating a todo with all the remaining offences and gradually release each fix. this way we'll already have a configuration in place and be able to adopt it in new pull requests

[codecov[bot]]

Codecov Report

:x: Patch coverage is 94.62366% with 15 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 88.06%. Comparing base (839752f) to head (c5484db).

Files with missing lines	Patch %	Lines
...erators/solidus_admin/install/install_generator.rb	0.00%	4 Missing :warning:
.../controllers/solidus_admin/addresses_controller.rb	57.14%	3 Missing :warning:
...app/controllers/solidus_admin/orders_controller.rb	75.00%	2 Missing :warning:
...omponents/solidus_admin/products/show/component.rb	0.00%	1 Missing :warning:
...onents/solidus_admin/stock_items/edit/component.rb	0.00%	1 Missing :warning:
...n/ui/forms/address/fieldsets/location/component.rb	0.00%	1 Missing :warning:
...mponents/solidus_admin/ui/pages/index/component.rb	94.44%	1 Missing :warning:
...lidus_admin/users/store_credits/index/component.rb	66.66%	1 Missing :warning:
.../controllers/solidus_admin/customers_controller.rb	66.66%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6241      +/-   ##
==========================================
- Coverage   89.35%   88.06%   -1.30%     
==========================================
  Files         961      758     -203     
  Lines       20195    15284    -4911     
==========================================
- Hits        18046    13460    -4586     
+ Misses       2149     1824     -325     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.