Update licenses
Summary
Related to previous conversations in PR #5948. Copyright lists alphabetically the major contributors, points for generic contributions to the git commit list.
Some open issues:
- is the logo currently protected?
- is the brand "Solidus" currently protected?
- I also added inter
Fixes #5947
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
- [X] I have written a thorough PR description.
- [X] I have kept my commits small and atomic.
- [X] I have used clear, explanatory commit messages.
The following are not always needed:
@tvdeyen could you also look here
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.28%. Comparing base (
b1b8567) to head (fa21e97).
Additional details and impacted files
@@ Coverage Diff @@
## main #6084 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 813 813
Lines 17906 17906
=======================================
Hits 15987 15987
Misses 1919 1919
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tvdeyen I think I found all boilerplate licenses, please merge this.
@fthobe please use rebase to update this branch with main (and not merge), thanks 🙏🏻
@fthobe I found that we have individual
LICENSEfiles in most of the gems
admin
api
~~backend~~
core
~~legacy_promotions~~
~~promotions~~
sample
The
LICENSEfile in the root folder is not part of the bundled solidus gem.How to we handle this? My guess is that we need to update all individual licenses, because people are able to install just
solidus_apiand the license should still be available in the shipped gem package, right? Not sure how other mono-repos handles this.
So there are various approaches to that:
- we should as first step harmonise what can be harmonised: where licenses are identical we should refer to the parent license
- additional licenses in subfolders are perfectly fine but we should add at least a reference from parent folder more for clarity than hard legal requirements
Keep in mind that a referral to a valid license is as good as a valid license in most jurisdictions (actually Germany is a notable exception where there are for years final decisions pending if a license is valid if it can not be reviewed during the moment of purchase / acquisition of the software).