solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Add missing methods to null promotion configuration

Open mamhoff opened this issue 1 month ago • 2 comments

Summary

We've delegated a lot of configuration accessors from Spree::Config.instance to Spree::Config.promotions. When we switch the default configuration to be the Spree::Core::NullPromotionConfiguration (which does nothing), we need to have those setters in place, and we need them to issue deprecation warnings. This adds a configurable class that does nothing but issue many deprecation warnings, and adds the needed methods to Spree::Core::NullPromotionConfiguration.

For future readers: All of these deprecation warning will go away by using a non-stubbed promotion system, either the one in solidus_legacy_promotions or the one in the upcoming solidus_promotions.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

mamhoff avatar May 17 '24 12:05 mamhoff